This repository was archived by the owner on Jan 22, 2024. It is now read-only.
A couple of test tweaks#23
Merged
Merged
Conversation
so we can control qemu when running the test script interactively.
Otherwise we might try to contact tgtd before it's ready. See: https://src.fedoraproject.org/rpms/scsi-target-utils/c/3a25fe7a57200b61ecebcec0d867671597080196
7b84c82 to
94acd89
Compare
keszybz
reviewed
Dec 5, 2022
Comment on lines
+321
to
+323
| # Workaround for a race | ||
| # See: https://src.fedoraproject.org/rpms/scsi-target-utils/c/3a25fe7a57200b61ecebcec0d867671597080196 | ||
| sleep 5 |
Member
There was a problem hiding this comment.
Oh, so https://bugzilla.redhat.com/show_bug.cgi?id=848942 was opened against scsi-target-utils in F18, which was "forwarded" to https://bugs.freedesktop.org/show_bug.cgi?id=55431 in the upstream bugtracker for systemd, where Lennart asked a trivial follow-up question and the bug was closed three years later for lack of response. But systemd can hardly be responsible for tgtd not starting properly, so it would have been closed anyway.
The original bug remains untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered whilst debugging #21.