Conversation
This package predates SYMFLUENCE's register_model_bounds() seam, so HECHMS's
calibration bounds lived in the FRAMEWORK's shared catalogue and reached us
through symfluence.optimization.core.parameter_bounds_registry -- a module
deprecated for removal at SYMFLUENCE 2.0. Changing our own bounds therefore
required a framework release.
register() now contributes them through the seam, so get_model_bounds('HECHMS')
resolves what this package registers, ahead of the framework's built-in entry.
That works against current SYMFLUENCE and lets a later release drop the
compatibility entry.
No calibration result changes: the values come from this package's own
PARAM_BOUNDS, which were already the source for every other bounds consumer
here, and were verified identical to what the framework served -- 14 names,
matching on min, max AND transform, with no registration conflicts.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package predates SYMFLUENCE's
register_model_bounds()seam, so HECHMS's calibration bounds live in the framework's shared catalogue, reached throughsymfluence.optimization.core.parameter_bounds_registry— a module deprecated for removal at SYMFLUENCE 2.0. Changing our own bounds currently requires a framework release.register()now contributes them through the seam, soget_model_bounds('HECHMS')resolves what this package registers, ahead of the framework's built-in entry. This works against current SYMFLUENCE and lets a later framework release drop the compatibility entry.No calibration result changes. Values come from this package's own
PARAM_BOUNDS, already the source for every other bounds consumer here, and verified identical to what the framework served: 14 names, matching onmin,maxandtransform, withbounds_registration_conflicts()empty.Part of the SYMFLUENCE service-decomposition work: the framework is removing per-model knowledge from its core so the model suite can be extracted into its own distribution.
🤖 Generated with Claude Code