feat: use Node Watch for dynamic peer and REST discovery#22
Open
cryptoBeliever wants to merge 1 commit into
Open
feat: use Node Watch for dynamic peer and REST discovery#22cryptoBeliever wants to merge 1 commit into
cryptoBeliever wants to merge 1 commit into
Conversation
Contributor
Author
|
@Wayonb The GitHub Action build is failing, but it doesn’t appear to be related to my current changes, so I'm leaving it as is. It may be due to updates from the previous release (please correct me if I’m mistaken). Could you take a look at my changes when you have some time? It’s nothing urgent and can wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
NodeWatchService(new): fetches GET …/api/symbol/nodes/peer with only_ssl, limit, and order; maps API JSON to NodeWatchNodeInfo (hostname from endpoint, P2P port 7900).RemoteNodeService:getRestUrlsandgetPeerInfosusenodeWatchUrland a shared getNodeWatchNodes helper; removed createNodeApiRestClient and the statistics-service dependency.Health filtering: REST list uses isHealthy === true only. Peer list drops entries with isHealthy === false but keeps null or missing health as acceptable.Config / presets: statisticsServiceUrl, limits, and filters replaced by nodeWatchUrl, nodeWatchPeerLimit, and nodeWatchRestLimit in ConfigPreset and YAML presets.Dependencies: removed symbol-statistics-service-typescript-fetch-client from package.json / lockfile.Tests: added NodeWatchService.test.ts; RemoteNodeService.test.ts updated to stub getNodeWatchNodes.Breaking changes
Custom presets that still use statisticsServiceUrl / statisticsService* limits and filters must migrate to the new nodeWatch* fields.