[explorer] feat: display transfer messages in transaction details view#2383
Draft
cryptoBeliever wants to merge 3 commits into
Draft
[explorer] feat: display transfer messages in transaction details view#2383cryptoBeliever wants to merge 3 commits into
cryptoBeliever wants to merge 3 commits into
Conversation
Add frontend message formatting for plain, hex-prefixed, and encrypted transfer messages. Update tests and fixtures to use boolean isPlain.
Add frontend message formatting for plain, hex-prefixed, and encrypted transfer messages. Update tests and fixtures to use boolean isPlain.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2383 +/- ##
==========================================
+ Coverage 95.44% 96.95% +1.51%
==========================================
Files 657 276 -381
Lines 51116 21313 -29803
Branches 1359 206 -1153
==========================================
- Hits 48786 20664 -28122
+ Misses 2282 643 -1639
+ Partials 48 6 -42
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
… field Update explorer transfer message parsing to use `message.type` from lightapi instead of `isPlain`/`is_plain`, and align puller/rest payload mapping and tests with the new schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typeMotivation
Transfer message presentation depends on whether a message is plain or encrypted. The REST API exposes
typeas a numeric; the frontend applies formatting rules:type=1, nofeprefix → decode hex payload to UTF-8type=1,feprefix → show asHEX: <payload>type=2→ show encrypted payload as-is with a dedicated labelDepends on
Issue: #2352
SQL migration