Conversation
Deploying with
|
| Latest commit: |
2820cd6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://05df999c.swim-ui.pages.dev |
| Branch Preview URL: | https://test-if-need-dummy-connectio.swim-ui.pages.dev |
swimthor
force-pushed
the
test-if-need-dummy-connection
branch
from
October 10, 2022 10:24
2bd05a3 to
96f6c0c
Compare
wormat
previously approved these changes
Oct 10, 2022
swimthor
force-pushed
the
test-if-need-dummy-connection
branch
from
October 26, 2022 16:35
96f6c0c to
2820cd6
Compare
wormat
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It passes the qa full test in https://exsphere.slack.com/archives/C02PVCS2PKQ/p1665410870060659?thread_ts=1665393074.911999&cid=C02PVCS2PKQ
To be honest I didn't see any actual code change in
@solana/web3.jssince #284 (comment). But I am align with Andrew this dummy ws is not needed because when we need the onSignature ws, it will create a new ws connection via https://github.com/solana-labs/solana-web3.js/blob/master/src/connection.ts#L5025-L5028Notion ticket: https://www.notion.so/exsphere/Investigate-whether-we-still-need-a-dummy-websocket-connection-in-SolanaConnection-018975be2b1749a3b636644a07e2e5b9
Checklist