Skip to content

Assorted terminal fixes - #29

Open
wenottingham wants to merge 3 commits into
swesterfeld:masterfrom
wenottingham:assorted-term-fixes
Open

wenottingham wants to merge 3 commits into
swesterfeld:masterfrom
wenottingham:assorted-term-fixes

Conversation

@wenottingham

Copy link
Copy Markdown
Contributor
  • catch terminal resizes on track change
  • rename function to avoid having to #undef getch
  • use atexit() to reset terminal settings in case of crash

@swesterfeld

Copy link
Copy Markdown
Owner

I merged the first two commits, which look good. I didn't merge the atexit changes, because they don't really help if the program terminates abnormally.

For this, we would need to handle SIGTERM, SIGHUP, SIGQUIT and fatal signals like SIGABRT, SIGSEGV.

@swesterfeld swesterfeld left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't merge the atexit changes, because they don't really help if the program terminates abnormally.

For this, we would need to handle SIGTERM, SIGHUP, SIGQUIT and fatal signals like SIGABRT, SIGSEGV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants