travis has been dead for years, have some actions - #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1.
the repo had no ci at all —
deploy-image.shis still travis-based, so #16, #17 and #18 all merged on nothing but local verification.golang:1.12, the same image the dockerfile builds with, so ci can't drift from the release builddeploy-image.shreleases (amd64, arm64, armv7, armv6) via--build-arg GOARCH, no emulation since go cross-compilesverified all four locally and checked the binaries are actually per-arch, not four copies of amd64:
two things deliberately left out:
handler.go,main.go,router.go,client.goandstats.goall have pre-existing drift, so it would be red on arrival. worth a separate cleanup commit.the docker job takes ~10min because the dockerfile does
COPY . /build/beforego build, so each arch redownloads modules. restructuring it to copy go.mod/go.sum first would fix that, also separate.