Skip to content

Fix #227: properly display SW360Error details on 4xx/5xx by checking response is not None #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhruvv16-hash wants to merge 2 commits into from
Closed

Fix #227: properly display SW360Error details on 4xx/5xx by checking response is not None #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b98737f
Fix #227: properly display SW360Error details on 4xx/5xx by checking …
dhruvv16-hash Sep 10, 2026
8e34cbc
Fix unreachable code in mypy check
dhruvv16-hash Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions capycli/bom/check_bom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def _find_by_id(self, component: Component) -> Optional[Dict[str, Any]]:
print(
" " + component.name + ", " + version +
", " + sw360id)
if swex.response:
if swex.response is not None:
print(" Status Code: " + str(swex.response.status_code))
Comment on lines +69 to 70
if swex.message:
print(" Message: " + swex.message)
Expand Down Expand Up @@ -105,7 +105,7 @@ def _find_by_name(self, component: Component) -> Optional[Dict[str, Any]]:
print(Fore.LIGHTRED_EX + " Error retrieving release data: ")
print(
" " + component.name + ", " + version)
if swex.response:
if swex.response is not None:
print(" Status Code: " + str(swex.response.status_code))
if swex.message:
print(" Message: " + swex.message)
Expand Down
6 changes: 3 additions & 3 deletions capycli/project/create_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,12 @@ def update_project(self, project_id: str, project: Optional[Dict[str, Any]],
if swex.response.status_code == requests.codes["forbidden"]:
print_red(" You are not authorized - do you have a valid write token?")
sys.exit(ResultCode.RESULT_AUTH_ERROR)
if swex.response:
print_red(" " + str(swex.response.status_code) + ": " + swex.response.text)
sys.exit(ResultCode.RESULT_ERROR_ACCESSING_SW360)
if swex.details:
print_red(" " + swex.details.get("error", "") + ": " + swex.details.get("message", ""))
sys.exit(ResultCode.RESULT_ERROR_ACCESSING_SW360)
if swex.response.text:
print_red(" " + str(swex.response.status_code) + ": " + swex.response.text)
sys.exit(ResultCode.RESULT_ERROR_ACCESSING_SW360)

print_red(" Unknown error updating project: " + repr(swex))
sys.exit(ResultCode.RESULT_ERROR_ACCESSING_SW360)
Expand Down