Update to current version of realword spec + api, including e2e tests - #209
Open
c4ffein wants to merge 7 commits into
Open
Update to current version of realword spec + api, including e2e tests#209c4ffein wants to merge 7 commits into
c4ffein wants to merge 7 commits into
Conversation
|
@c4ffein is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I am the current owner of the RealWorld project and this PR makes the SvelteKit demo work with the current backend, as verified by the E2E test suite (minor glitches remain, can fix in a followup PR)
E2E tests are included, with a mechanism to keep them up to date (shell scripts to check parity of the vendored files, running in CI)
Svelte is not my main framework, don't hesitate to tell me if anything looks wrong and I can adapt my code
Also don't hesitate to tell me if you'd rather have me split this pr into smaller ones
Thanks for the framework and the talks!