fix(map): "Line 18" should be "Pārāyanavagga journey" - #438
Open
agilgur5 wants to merge 1 commit into
Open
Conversation
- it has a name, so shouldn't be "Line 18", which doesn't match any other data point and is visible on the site/map - this matches "Mahāparinibbāna journey" a [bit lower down](https://github.com/suttacentral/sc-data/blob/e8eb11d30c5a381bb44d83691ecc89ea7bce425b/additional-info/map_data.json#L3307) - this is the "line" between each coordinate, i.e. the path itself of the journey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This item has a name, so it shouldn't be "Line 18"
Details
the ambiguous number "Line 18" doesn't match any other data point and is visible on the site/map:
screenshots:
the new name, "Pārāyanavagga journey", matches "Mahāparinibbāna journey" a bit lower down
References
Saw and root caused this when looking at suttacentral/suttacentral#3679