v1.1.26: fix abort bug#89
Open
heushreck wants to merge 1 commit into
Open
Conversation
|
|
There was a problem hiding this comment.
1 issue found across 8 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="skills/superglue/references/odbc.md">
<violation number="1" location="skills/superglue/references/odbc.md:39">
P2: The supported-drivers table now implies SQL Anywhere uses default port 5000, which conflicts with the later SQL Anywhere section (2638). This can mislead connection setup.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| | `FreeTDS` | SAP ASE (Sybase), SQL Server | 5000 | | ||
| | Driver | Database | Default Port | | ||
| | --------- | ------------------------------------------ | ------------ | | ||
| | `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000 | |
There was a problem hiding this comment.
P2: The supported-drivers table now implies SQL Anywhere uses default port 5000, which conflicts with the later SQL Anywhere section (2638). This can mislead connection setup.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At skills/superglue/references/odbc.md, line 39:
<comment>The supported-drivers table now implies SQL Anywhere uses default port 5000, which conflicts with the later SQL Anywhere section (2638). This can mislead connection setup.</comment>
<file context>
@@ -34,9 +34,9 @@ The path contains the **database name**. The ODBC driver is specified via the `D
-| `FreeTDS` | SAP ASE (Sybase), SQL Server | 5000 |
+| Driver | Database | Default Port |
+| --------- | ------------------------------------------ | ------------ |
+| `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000 |
Additional query parameters (beyond `DRIVER`) are passed through to the ODBC connection string as key=value pairs.
</file context>
Suggested change
| | `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000 | | |
| | `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000 (ASE/SQL Server), 2638 (SQL Anywhere) | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-synced from hosted repository
Version: 1.1.26
Original PR: https://github.com/superglue-ai/superglue-hosted/pull/607
Author: @stefanfaistenauer
Summary by cubic
Fixes request cancellation by wiring
AbortSignalthroughSuperglueClientand the tool registry so canceled runs stop cleanly and surfaceAbortErrorinstead of generic failures.signal?: AbortSignaltoSuperglueClient.runTool,runTool(createRun), andrunStep, and passed it torestRequest.ctx.abortSignalto tool and system executions in the registry.AbortErrorin registry catch blocks to avoid converting cancellations into failed results.Written for commit 599896552cd27bc66f85861a25a6a1ebae7c9649. Summary will update on new commits.