Skip to content

v1.1.26: fix abort bug#89

Open
heushreck wants to merge 1 commit into
mainfrom
sync-from-hosted-1778154515
Open

v1.1.26: fix abort bug#89
heushreck wants to merge 1 commit into
mainfrom
sync-from-hosted-1778154515

Conversation

@heushreck
Copy link
Copy Markdown

Auto-synced from hosted repository

Version: 1.1.26
Original PR: https://github.com/superglue-ai/superglue-hosted/pull/607
Author: @stefanfaistenauer


Summary by cubic

Fixes request cancellation by wiring AbortSignal through SuperglueClient and the tool registry so canceled runs stop cleanly and surface AbortError instead of generic failures.

  • Bug Fixes
    • Added signal?: AbortSignal to SuperglueClient.runTool, runTool (createRun), and runStep, and passed it to restRequest.
    • Passed ctx.abortSignal to tool and system executions in the registry.
    • Re-threw AbortError in registry catch blocks to avoid converting cancellations into failed results.
    • Canceled runs now terminate network calls and no longer show misleading error messages.

Written for commit 599896552cd27bc66f85861a25a6a1ebae7c9649. Summary will update on new commits.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 8 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="skills/superglue/references/odbc.md">

<violation number="1" location="skills/superglue/references/odbc.md:39">
P2: The supported-drivers table now implies SQL Anywhere uses default port 5000, which conflicts with the later SQL Anywhere section (2638). This can mislead connection setup.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

| `FreeTDS` | SAP ASE (Sybase), SQL Server | 5000 |
| Driver | Database | Default Port |
| --------- | ------------------------------------------ | ------------ |
| `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000 |
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The supported-drivers table now implies SQL Anywhere uses default port 5000, which conflicts with the later SQL Anywhere section (2638). This can mislead connection setup.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At skills/superglue/references/odbc.md, line 39:

<comment>The supported-drivers table now implies SQL Anywhere uses default port 5000, which conflicts with the later SQL Anywhere section (2638). This can mislead connection setup.</comment>

<file context>
@@ -34,9 +34,9 @@ The path contains the **database name**. The ODBC driver is specified via the `D
-| `FreeTDS` | SAP ASE (Sybase), SQL Server | 5000         |
+| Driver    | Database                                   | Default Port |
+| --------- | ------------------------------------------ | ------------ |
+| `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000         |
 
 Additional query parameters (beyond `DRIVER`) are passed through to the ODBC connection string as key=value pairs.
</file context>
Suggested change
| `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000 |
| `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000 (ASE/SQL Server), 2638 (SQL Anywhere) |
Fix with Cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants