Conversation
|
|
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="skills/superglue/references/odbc.md">
<violation number="1" location="skills/superglue/references/odbc.md:39">
P2: The supported-drivers table lists port `5000` for SQL Anywhere, but the SQL Anywhere section says its default is `2638`. This inconsistency can cause incorrect connection setup.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| | `FreeTDS` | SAP ASE (Sybase), SQL Server | 5000 | | ||
| | Driver | Database | Default Port | | ||
| | --------- | ------------------------------------------ | ------------ | | ||
| | `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000 | |
There was a problem hiding this comment.
P2: The supported-drivers table lists port 5000 for SQL Anywhere, but the SQL Anywhere section says its default is 2638. This inconsistency can cause incorrect connection setup.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At skills/superglue/references/odbc.md, line 39:
<comment>The supported-drivers table lists port `5000` for SQL Anywhere, but the SQL Anywhere section says its default is `2638`. This inconsistency can cause incorrect connection setup.</comment>
<file context>
@@ -34,9 +34,9 @@ The path contains the **database name**. The ODBC driver is specified via the `D
-| `FreeTDS` | SAP ASE (Sybase), SQL Server | 5000 |
+| Driver | Database | Default Port |
+| --------- | ------------------------------------------ | ------------ |
+| `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000 |
Additional query parameters (beyond `DRIVER`) are passed through to the ODBC connection string as key=value pairs.
</file context>
Suggested change
| | `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000 | | |
| | `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000 (ASE/SQL Server), 2638 (SQL Anywhere) | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-synced from hosted repository
Version: 1.1.26
Original PR: https://github.com/superglue-ai/superglue-hosted/pull/603
Author: @stefanfaistenauer
Summary by cubic
Add email notifications as a first-class channel alongside Slack, with rules, summaries, and a simpler admin UI. Also fixes MSSQL string parameter typing and an agent tool execution edge case.
New Features
EmailChannelCardandSlackChannelCardwith shared rule editor; removed the legacyNotificationsView.@superglue/sharedand used in API and web forms.Bug Fixes
NVarCharto prevent encoding issues.TOOL_POLICIES.computeModeFromInput).Written for commit ca83a813cb18ca88e511379aaf73f2b03a9beea2. Summary will update on new commits.