Skip to content

v1.1.26: Fixes/bugs#87

Open
heushreck wants to merge 1 commit intomainfrom
sync-from-hosted-1778075360
Open

v1.1.26: Fixes/bugs#87
heushreck wants to merge 1 commit intomainfrom
sync-from-hosted-1778075360

Conversation

@heushreck
Copy link
Copy Markdown

Auto-synced from hosted repository

Version: 1.1.26
Original PR: https://github.com/superglue-ai/superglue-hosted/pull/603
Author: @stefanfaistenauer


Summary by cubic

Add email notifications as a first-class channel alongside Slack, with rules, summaries, and a simpler admin UI. Also fixes MSSQL string parameter typing and an agent tool execution edge case.

  • New Features

    • Email channel: immediate and summary emails via backend notifier and scheduler; settings include recipients, from address, and rules; API/client updated to support it.
    • New admin UI: EmailChannelCard and SlackChannelCard with shared rule editor; removed the legacy NotificationsView.
    • Centralized email validation in @superglue/shared and used in API and web forms.
    • Org invites now support selecting role (member/admin).
  • Bug Fixes

    • MSSQL: pass string parameters as NVarChar to prevent encoding issues.
    • Agent tools: attach execute when mode is input-dependent (TOOL_POLICIES.computeModeFromInput).
    • Summary worker: processes Slack and Email rules independently for daily/weekly summaries.

Written for commit ca83a813cb18ca88e511379aaf73f2b03a9beea2. Summary will update on new commits.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 5 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="skills/superglue/references/odbc.md">

<violation number="1" location="skills/superglue/references/odbc.md:39">
P2: The supported-drivers table lists port `5000` for SQL Anywhere, but the SQL Anywhere section says its default is `2638`. This inconsistency can cause incorrect connection setup.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

| `FreeTDS` | SAP ASE (Sybase), SQL Server | 5000 |
| Driver | Database | Default Port |
| --------- | ------------------------------------------ | ------------ |
| `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000 |
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The supported-drivers table lists port 5000 for SQL Anywhere, but the SQL Anywhere section says its default is 2638. This inconsistency can cause incorrect connection setup.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At skills/superglue/references/odbc.md, line 39:

<comment>The supported-drivers table lists port `5000` for SQL Anywhere, but the SQL Anywhere section says its default is `2638`. This inconsistency can cause incorrect connection setup.</comment>

<file context>
@@ -34,9 +34,9 @@ The path contains the **database name**. The ODBC driver is specified via the `D
-| `FreeTDS` | SAP ASE (Sybase), SQL Server | 5000         |
+| Driver    | Database                                   | Default Port |
+| --------- | ------------------------------------------ | ------------ |
+| `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000         |
 
 Additional query parameters (beyond `DRIVER`) are passed through to the ODBC connection string as key=value pairs.
</file context>
Suggested change
| `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000 |
| `FreeTDS` | SAP ASE (Sybase), SQL Anywhere, SQL Server | 5000 (ASE/SQL Server), 2638 (SQL Anywhere) |
Fix with Cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants