Repository navigation
fix(acceptance): poll current content after writes to tolerate CDN invalidation lag - #1690
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block approval of the object-versioning acceptance-test polling changes.
No open issues 🎉
What changed in this PR
This PR reduces flakiness in object-versioning acceptance tests by allowing time for asynchronous CDN cache invalidation after writes.
Changes:
- Adds a helper that polls current content every second for up to 15 seconds, tolerating stale bodies and cached HTTP 400 responses.
- Replaces six immediate content assertions with polling assertions.
| File | Description |
|---|---|
acceptance/specs/rest-object-versioning.test.ts |
Adds bounded polling and applies it to current-content checks after writes. |
Review effort: Balanced
TylerHillery
force-pushed
the
tyler/fix/versioning-acceptance-cdn-flake
branch
from
November 10, 2026 17:25
327ad50 to
07c36f7
Compare
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Coverage Report for CI Build 42901688966Coverage remained the same at 87.601%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
ferhatelmas
reviewed
Nov 10, 2026
ferhatelmas
reviewed
Nov 10, 2026
ferhatelmas
reviewed
Nov 10, 2026
ferhatelmas
approved these changes
Nov 10, 2026
TylerHillery
force-pushed
the
tyler/fix/versioning-acceptance-cdn-flake
branch
from
November 10, 2026 21:05
89aa623 to
4ca9f80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Some versioning acceptance tests read an object's current content, write to it, then read it again right away. The CDN caches
GET /object/authenticated/...and invalidates it asynchronously, so the second read can return the old body. This flaked in staging ap-southeast-1: https://github.com/supabase/storage-acceptance-runner/actions/runs/42855634166What is the new behavior?
Those re-reads now poll for the expected content (1s interval, up to 15s) so the CDN cache has time to be invalidated.
Additional context
N/A