Repository navigation
feat(ci): run tests and type checks on pull requests - #371
Merged
mattrossman merged 34 commits intoOct 8, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
mattrossman
marked this pull request as ready for review
October 7, 2026 19:02
barryroodt
approved these changes
Oct 8, 2026
barryroodt
left a comment
Contributor
There was a problem hiding this comment.
Looks good to merge from my side! Nice touch giving the bot push its own concurrency group so it can't cancel the run that pushed it. One small thing:
pnpm check now fails with a missing script. The rename to test left a few docs pointing at the old command, and the README still says it "Runs typechecks plus local smoke tests" when pnpm test doesn't typecheck:
Collaborator
Author
|
@barryroodt just fixed up those docs to use the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We have unit / e2e tests across
apps/*andpackages/*but don't run them or type checks in CI, so they quietly regress (e.g. #351 broke a Codex parser test that #366 added the same day).Changes
typecheckjob next toformattest,test-platform-lite(which is slow enough for its own parallel job), andtest-docker. The Docker tests take ~2.5 min, so they only run when a PR touches relevant files (skipped example).[skip ci](added in ci: skip CI on the generated eval results commit #332) and push with our GH App token instead, so required checks run on them without approval. Arun-evals-changedrefresh's results commit ran CI as the app with no approval prompt and didn't start another refresh.Example with tests failing (run):
I added
OPENAI_API_KEYto Dependabot secrets so Tests runs on Dependabot PRs. Fork PRs don't get secrets as is the case on supabase/mcp.Follow-ups
format,typecheck,test,test-platform-lite, andtest-dockeron themain: review requiredruleset.Closes AI-1121