Skip to content

feat(ci): run tests and type checks on pull requests - #371

Merged
mattrossman merged 34 commits into
mainfrom
mattrossman/ai-1121-require-tests-in-evals-ci-checks
Oct 8, 2026
Merged

mattrossman merged 34 commits into
mainfrom
mattrossman/ai-1121-require-tests-in-evals-ci-checks

Conversation

@mattrossman

@mattrossman mattrossman commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

We have unit / e2e tests across apps/* and packages/* but don't run them or type checks in CI, so they quietly regress (e.g. #351 broke a Codex parser test that #366 added the same day).

Changes

  • Code Quality gets a typecheck job next to format
  • A new Tests workflow runs test, test-platform-lite (which is slow enough for its own parallel job), and test-docker. The Docker tests take ~2.5 min, so they only run when a PR touches relevant files (skipped example).
  • Refresh results commits drop [skip ci] (added in ci: skip CI on the generated eval results commit #332) and push with our GH App token instead, so required checks run on them without approval. A run-evals-changed refresh's results commit ran CI as the app with no approval prompt and didn't start another refresh.
  • Upgraded to Vitest v5 so we get per-package labels on the job summary (compare before and after).
Tests Code Quality
CleanShot 2026-10-07 at 4 16 00 PM@2x CleanShot 2026-10-07 at 3 37 37 PM@2x

Example with tests failing (run):

CleanShot 2026-10-07 at 2 24 36 PM@2x

I added OPENAI_API_KEY to Dependabot secrets so Tests runs on Dependabot PRs. Fork PRs don't get secrets as is the case on supabase/mcp.

Follow-ups

  • After merge, require format, typecheck, test, test-platform-lite, and test-docker on the main: review required ruleset.
  • AI-934: replace the framework smoke tests with per-scorer Vitest files.
  • AI-1295: cut platform-lite setup time with PGlite snapshots.

Closes AI-1121

@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
evals Ignored Ignored Preview Oct 8, 2026 1:06pm UTC

Request Review

@mattrossman mattrossman added the run-evals-changed Add to a PR to refresh only the benchmark evals that have had changes label Oct 6, 2026
@mattrossman mattrossman removed the run-evals-changed Add to a PR to refresh only the benchmark evals that have had changes label Oct 6, 2026
@mattrossman mattrossman added the run-evals-changed Add to a PR to refresh only the benchmark evals that have had changes label Oct 7, 2026
@mattrossman mattrossman removed the run-evals-changed Add to a PR to refresh only the benchmark evals that have had changes label Oct 7, 2026
@mattrossman mattrossman added the run-evals-changed Add to a PR to refresh only the benchmark evals that have had changes label Oct 7, 2026
@mattrossman mattrossman removed the run-evals-changed Add to a PR to refresh only the benchmark evals that have had changes label Oct 7, 2026
@mattrossman mattrossman added the run-evals-changed Add to a PR to refresh only the benchmark evals that have had changes label Oct 7, 2026
@mattrossman mattrossman removed the run-evals-changed Add to a PR to refresh only the benchmark evals that have had changes label Oct 7, 2026
@mattrossman
mattrossman marked this pull request as ready for review October 7, 2026 19:02
@mattrossman
mattrossman requested a review from a team as a code owner October 7, 2026 19:02
@mattrossman mattrossman changed the title feat(ci): run tests on pull requests feat(ci): run tests and type checks on pull requests Oct 7, 2026

@barryroodt barryroodt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge from my side! Nice touch giving the bot push its own concurrency group so it can't cancel the run that pushed it. One small thing:

pnpm check now fails with a missing script. The rename to test left a few docs pointing at the old command, and the README still says it "Runs typechecks plus local smoke tests" when pnpm test doesn't typecheck:

@mattrossman

Copy link
Copy Markdown
Collaborator Author

@barryroodt just fixed up those docs to use the new pnpm test and pnpm typecheck scripts 👍

@mattrossman
mattrossman merged commit ce9d503 into main Oct 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants