Skip to content

fix(admin): allow application and organization social provider setup - #13

Merged
SirNarsh merged 1 commit into
mainfrom
fix/scoped-social-provider-forms
Oct 4, 2026
Merged

SirNarsh merged 1 commit into
mainfrom
fix/scoped-social-provider-forms

Conversation

@SirNarsh

@SirNarsh SirNarsh commented Oct 4, 2026

Copy link
Copy Markdown
Member

Summary

  • Omit control_login_enabled from application and organization provider PUT requests.
  • Preserve the installation checkbox and the backend installation-only restriction.
  • Cover Google, Apple, Microsoft, Facebook, and LinkedIn forms at all three scopes, including checked and unchecked installation flags.

Verification

  • All 12 navigation Playwright tests passed, including three scope regressions.
  • Admin typecheck, lint, and static build passed (existing image-element lint warning unchanged).
  • No backend, API, database, or provider protocol changes.
  • Live provider authentication and production deployment are not included in these local results.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused implementation matches backend scope restrictions and includes comprehensive regression coverage.

Review effort: Balanced
Findings: None

What changed in this PR

Fixes social-provider configuration at organization and application scopes by omitting the installation-only Platform login field.

Changes:

  • Conditionally includes control_login_enabled only for installation requests.
  • Adds Playwright coverage for five providers across all three scopes.
File Description
web/​app/​page.tsx Restricts the Platform login payload field to installation scope.
web/​e2e/​navigation.spec.ts Verifies provider forms, endpoints, and payloads across scopes.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@SirNarsh
SirNarsh merged commit 96f12d0 into main Oct 4, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants