Repository navigation
fix(auth): restore social registration and explicit linking - #12
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Enrollment verification can bypass a newly enabled invite-only policy, and its test cleanup leaves domain-event records behind.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Fixes PostgreSQL social-registration metadata typing while documenting and testing registration/linking behavior.
Changes:
- Cast identity email metadata parameters to PostgreSQL text.
- Add registration, linking, isolation, enrollment, and replay regressions.
- Expand admin documentation and enforce CI execution.
| File | Description |
|---|---|
web/app/page.tsx |
Clarifies registration policy help. |
internal/httpapi/google_auth.go |
Fixes email metadata parameter typing. |
internal/httpapi/external_identity_registration_integration_test.go |
Adds social identity regressions. |
internal/httpapi/external_email_enrollment.go |
Fixes enrollment metadata typing. |
internal/httpapi/external_email_enrollment_integration_test.go |
Tests enrollment success and replay rejection. |
docs/application-configuration.md |
Documents registration and linking behavior. |
.github/workflows/verify.yml |
Requires regressions to execute in CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Verification
No database migration or API-contract change. Live provider verification and deployment are not included in these local results.