Added null protection on validation#61
Open
rcerljenko wants to merge 1 commit into
Open
Conversation
Author
|
@sunspikes could you take a look please.. thanks! |
Owner
|
@rcerljenko sorry that i missed this PR, If you just want the field to accept null values, did you try: https://laravel.com/docs/9.x/validation#rule-nullable You could basically do |
|
Adding In particular: I think the best approach, in line with standard Laravel rules, would be to let the rule return |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use this package in our company and we had a situation when frontend sends a
nullvalue to the validated field causing anTypeErrorexception to be thrown like so:This PR resolves that by skipping a validation if the validated field is
null.