Skip to content

added an acronym for rank too long #43#55

Open
akashrajxyz wants to merge 1 commit into
sudiptob2:mainfrom
akashrajxyz:feature
Open

added an acronym for rank too long #43#55
akashrajxyz wants to merge 1 commit into
sudiptob2:mainfrom
akashrajxyz:feature

Conversation

@akashrajxyz

Copy link
Copy Markdown

#43

@sudiptob2 sudiptob2 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit test.

Comment thread app/constant.py

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can keep the default length to 10. And please check for "grandmaster" rank it works or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants