Open
Conversation
to define a custom list of nameservers to be included in configs
|
Kudos, SonarCloud Quality Gate passed!
|
clementperon
approved these changes
Mar 7, 2023
metalcated
approved these changes
Mar 7, 2023
metalcated
left a comment
There was a problem hiding this comment.
Looks good to me and finally someone did this! Nice work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








to: @subspacecommunity/subspace-maintainers
Background
If
SUBSPACE_DISABLE_DNSis set totrue, but a client uses nameservers in his local subnet (e.g. his IP address is10.0.0.2, netmask/24, home gateway and caching DNS server -10.0.0.1), he won't be able to reach it. It can be solved partially by adding all private subnets to an exclusion list:but in some cases that local DNS server still will be unavailable (e.g. if kill-switch mode is enabled).
Changes
Now, if variable
SUBSPACE_CLIENT_NAMESERVERSis set and contain a valid comma-separated list of DNS servers, this list will be included in a client config as is.Example: