Skip to content

Tutorial to understand SDP and FFT#36

Open
NimaSarajpoor wants to merge 22 commits intomainfrom
Tutorial_FFT_based_SDP
Open

Tutorial to understand SDP and FFT#36
NimaSarajpoor wants to merge 22 commits intomainfrom
Tutorial_FFT_based_SDP

Conversation

@NimaSarajpoor
Copy link
Copy Markdown
Collaborator

I have been trying to better understand how sliding-dot-product and convolution are related, and what type of convolution we are talking about... and how that convolution is related to mode 'valid' in scipy's convolve. And, eventually, how oaconvolve works. So, I decided to prepare a short tutorial to help me understand these components.

@seanlaw
I've created a .md file (draft version). I then noticed there are bunch of stuff that a reader may want to execute. So, I am thinking of moving the context into a jupyter notebook.

@gitnotebooks
Copy link
Copy Markdown

gitnotebooks Bot commented Jan 12, 2026

@seanlaw
Copy link
Copy Markdown
Contributor

seanlaw commented Jan 12, 2026

I was hoping that you'd write a tutorial notebook! Glad that we're on the same page.

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Comment thread docs/Tutorial_FFT_Based_SDP.ipynb
Comment thread docs/Tutorial_FFT_Based_SDP.ipynb
Comment thread docs/Tutorial_FFT_Based_SDP.ipynb
Comment thread docs/Tutorial_FFT_Based_SDP.ipynb
Comment thread docs/Tutorial_FFT_Based_SDP.ipynb
Comment thread docs/Tutorial_FFT_Based_SDP.ipynb
Comment thread docs/Tutorial_FFT_Based_SDP.ipynb
@NimaSarajpoor
Copy link
Copy Markdown
Collaborator Author

@seanlaw
Can you please checkout the added tutorial in this PR, and let me know if its story is easy to follow? Please let me know if you think I should restructure it.

@NimaSarajpoor NimaSarajpoor requested a review from seanlaw January 15, 2026 03:50
Copy link
Copy Markdown
Contributor

@seanlaw seanlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NimaSarajpoor I think that the story isn't clear and it's probably because you are using too much text/code to motivate your point, which results in your point be lost/hard to follow.

I want to draw your attention to the original Matrix Profile Tutorial where we leverage a ton of visuals to help explain the concepts. It's certainly a lot more work but notice that, at most, we have 6 lines of code within a cell but that code is trivial to follow and the visuals help guide us step-by-step.

In my mind, I think Figure 1 from the MASS paper (and variations of it) will help people "see" your points more clearly and how each method is the same/different. Right now, it feels like you are jumping from one concept to another and then hoping that, by providing code, the reader will be convinced all on their own. Instead, you should focus on one singular (clear) point and prove your point before moving on (i.e., build things up one-clear-step-at-a-time!).

Comment thread docs/Tutorial_FFT_Based_SDP.ipynb Outdated
Comment thread docs/Tutorial_FFT_Based_SDP.ipynb Outdated
Comment thread docs/Tutorial_FFT_Based_SDP.ipynb Outdated
Comment thread docs/Tutorial_FFT_Based_SDP.ipynb Outdated
Comment thread docs/Tutorial_FFT_Based_SDP.ipynb Outdated
Comment thread docs/Tutorial_FFT_Based_SDP.ipynb Outdated
@NimaSarajpoor
Copy link
Copy Markdown
Collaborator Author

... using too much text/code to motivate your point, which results in your point be lost/hard to follow.

I want to draw your attention to the original Matrix Profile Tutorial where we leverage a ton of visuals to help explain the concepts. It's certainly a lot more work but notice that, at most, we have 6 lines of code within a cell but that code is trivial to follow and the visuals help guide us step-by-step.

Agree... It feels like I have not been staying on one single line, and instead making small jumps to left and right.

In my mind, I think Figure 1 from the MASS paper (and variations of it) will help people "see" your points more clearly and how each method is the same/different.

I will also read that paper. I think it should help me structure my thoughts and improve the flow of this tutorial.

@NimaSarajpoor
Copy link
Copy Markdown
Collaborator Author

NimaSarajpoor commented Jan 15, 2026

@seanlaw
FYI: A few comments of yours that appeared on this PR page shows 2 days ago. Did you review at that time as well?! There are some that shows an hour ago or so... and if I go to the "Files changed" section, I can see those comments there too. Cannot see any of your comments when I click on ReviewNB though

@seanlaw
Copy link
Copy Markdown
Contributor

seanlaw commented Jan 15, 2026

FYI: A few comments of yours that appeared on this PR page shows 2 days ago. Did you review at that time as well?!

Yes, I started the other day but wanted to let you finish since I knew you weren't done. I am trying to move away from ReviewNB for reviewing notebooks

@NimaSarajpoor
Copy link
Copy Markdown
Collaborator Author

@seanlaw
Apologies for the delay, and thanks for your patience. I’ve now addressed the comments. This is ready for another look. I reviewed the figures in the MASS paper published in 2024 , but found them difficult to follow. So, I decided to use animations as much as possible.

Disclaimer: I used LLMs to generate scripts for creating the GIFs included in the tutorial. I've decided to not add those scripts to the repo.

@seanlaw
Copy link
Copy Markdown
Contributor

seanlaw commented Apr 29, 2026

Thanks @NimaSarajpoor! I will find some time to review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants