Tutorial to understand SDP and FFT#36
Conversation
|
Review these changes at https://app.gitnotebooks.com/stumpy-dev/sliding_dot_product/pull/36 |
|
I was hoping that you'd write a tutorial notebook! Glad that we're on the same page. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@seanlaw |
There was a problem hiding this comment.
@NimaSarajpoor I think that the story isn't clear and it's probably because you are using too much text/code to motivate your point, which results in your point be lost/hard to follow.
I want to draw your attention to the original Matrix Profile Tutorial where we leverage a ton of visuals to help explain the concepts. It's certainly a lot more work but notice that, at most, we have 6 lines of code within a cell but that code is trivial to follow and the visuals help guide us step-by-step.
In my mind, I think Figure 1 from the MASS paper (and variations of it) will help people "see" your points more clearly and how each method is the same/different. Right now, it feels like you are jumping from one concept to another and then hoping that, by providing code, the reader will be convinced all on their own. Instead, you should focus on one singular (clear) point and prove your point before moving on (i.e., build things up one-clear-step-at-a-time!).
Agree... It feels like I have not been staying on one single line, and instead making small jumps to left and right.
I will also read that paper. I think it should help me structure my thoughts and improve the flow of this tutorial. |
|
@seanlaw |
Yes, I started the other day but wanted to let you finish since I knew you weren't done. I am trying to move away from ReviewNB for reviewing notebooks |
|
@seanlaw Disclaimer: I used LLMs to generate scripts for creating the GIFs included in the tutorial. I've decided to not add those scripts to the repo. |
|
Thanks @NimaSarajpoor! I will find some time to review it |
I have been trying to better understand how sliding-dot-product and convolution are related, and what type of convolution we are talking about... and how that convolution is related to mode 'valid' in scipy's convolve. And, eventually, how oaconvolve works. So, I decided to prepare a short tutorial to help me understand these components.
@seanlaw
I've created a
.mdfile (draft version). I then noticed there are bunch of stuff that a reader may want to execute. So, I am thinking of moving the context into a jupyter notebook.