Repository navigation
Merge to beta - #2035
Merged
Merged
Merge to beta#2035
Conversation
…e1833f2 (#2007) Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>
* Use dedicated v2 search request helper instead of path inference Committed-By-Agent: goose Orbit-Session-Id: bf0045b8-bfc9-4e18-ae11-5f042ce9add7 * Link search fix changefile to its pull request Committed-By-Agent: goose Orbit-Session-Id: bf0045b8-bfc9-4e18-ae11-5f042ce9add7 * Delete .hark/changes/2026-10-31_owner_v2-search-limit-metadata.change.md * Rebuild v2 search query from request params Committed-By-Agent: goose Orbit-Session-Id: bf0045b8-bfc9-4e18-ae11-5f042ce9add7
* Fix binary webhook payload parsing Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add webhook payload changefile Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com>
* Run full CI on canary branches Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Run canary CI from a separate workflow without publishing Move the build and test jobs into a reusable checks workflow called by both CI and a new Canary CI workflow. Canary CI runs on pushes to the canary-ga, canary-beta, and canary-private-preview branches, points stripe-mock at the matching canary specs and fixtures, and has no publish job. CI keeps publishing and no longer triggers on canary branches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Committed-By-Agent: claude * Share CI steps with Canary CI through local actions Replace the reusable checks workflow with composite actions for the build and test steps, used by both CI and Canary CI. Jobs stay in each workflow, so CI's check names (and the required status checks that match them) are unchanged. Canary CI keeps its own copy of the test matrix and has no publish job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Committed-By-Agent: claude --------- Co-authored-by: codex <noreply@openai.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
#1995) * Add error messages to help users debug signature verification failures. The stripe-signature header may now include additional metadata about the event destination and the event being sent. These can help narrow down the reason why signature verification failed. No changes are made to the verification process; this just updates how error messages are generated, if the metadata is present in the header. * Fix typos. * Guard against malformed key-value pairs in signature header.
…2022) * Fix account scoping on Event#fetch_related_object A directly-retrieved Event#fetch_related_object fell back to the retrieving client's own stripe_account instead of the event's own context, because _request's combine_opts merge re-applied the Event's retained @opts. EventNotification already avoids this by scoping its @client to the notification's context at construction time; Event now does the equivalent by routing _request through a context-scoped, account-free requestor. Fixes RUN_DEVSDK-3694 (ruby portion). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Committed-By-Agent: claude * Add PR URL to event-context-scoping changefile Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Committed-By-Agent: claude * Update 2026-11-06_jar_fix-event-context-scoping.change.md * Update 2026-11-06_jar_fix-event-context-scoping.change.md * Move Event context-scoping into a hand-maintained EventBase Event is generated from the OpenAPI spec, so the scoped_requestor/ _request override from the previous commit lived in a generated file with no durable home across regeneration. sdk-codegen (stripe/sdk-codegen#4349) now generates `Event < EventBase` instead of `Event < APIResource`; EventBase is a new hand-maintained class, autoloaded the same way as EventNotification, that carries the scoping logic verbatim. Regenerated via `just gen ruby --repo <this worktree>`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Committed-By-Agent: claude * Fix retained api_key/stripe_version loss in EventBase#_request, declare EventBase RBI EventBase#_request skipped RequestOptions.combine_opts(@opts, req_opts) entirely, so a retained per-object api_key or stripe_version override (e.g. from events.retrieve(id, api_key: 'rk_restricted')) was silently dropped on fetch_related_object, falling back to the ambient requestor's default. Restores the merge, with @opts's own stripe_account/stripe_context forced to the safe values first so a stale account can't leak back in through it. Also ships a hand-maintained rbi/stripe/resources/v2/core/event_base.rbi, mirroring event_notification.rbi, since EventBase is referenced as Event's superclass in the generated RBI but was otherwise undeclared anywhere in the packaged gem. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Committed-By-Agent: claude --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
* Omit API keys from Marshal and YAML serialization Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Make migration guide before/after examples equivalent Keep the Before and After snippets identical apart from the reattach step, and move the list/event usage into a separate example. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Committed-By-Agent: claude --------- Co-authored-by: codex <noreply@openai.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Remove CA certificates update instructions from README Removed instructions for updating bundled CA certificates. * Remove update-certs task Removed update-certs task from justfile. * Remove update_certs task and fetch_file method Removed the update_certs task and its related fetch_file method from the Rakefile. * Remove the unused curl link
Changes for upcoming major release
* Keep API keys out of inspect and as_json output The default Object#inspect renders every instance variable, so inspecting an EventNotification (or a StripeClient, APIRequestor, StripeConfiguration, or event notification handler) wrote the API key to logs. Override inspect on each, and override EventNotification#as_json so ActiveSupport's to_json no longer serializes the internal client. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Committed-By-Agent: claude * Drop EventNotification#as_json to keep the fix scoped to inspect Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Committed-By-Agent: claude --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
…ation (#2023) * Use the retained requestor, not the global one, for list/search pagination ApiResource#request_stripe_object already prefers a retained @requestor over the global active one, but ListObject and SearchResultObject only include Stripe::APIOperations::Request directly, so their next_page/ next_search_result_page calls always fell through to APIRequestor.active_requestor - even when the object was retrieved through an explicitly scoped client/requestor with its own account or base configuration. Thread an optional requestor override through execute_resource_request_internal, and have the instance-level execute_resource_request/execute_resource_request_stream pass their own retained @requestor when set, same as ApiResource already does. Class-level callers are unaffected since they never pass one. RUN_DEVSDK-3689 Committed-By-Agent: claude * Update request.rb * Refactor comment in retained_requestor method Simplify comment for retained_requestor method. * Add a streaming regression test for the retained-requestor fix Both existing regression tests cover the non-streaming path only, so the identical fix to execute_resource_request_stream had no coverage proving it actually works. Addresses stripe-ruby#2023 (review comment). Committed-By-Agent: claude * Test retained requestor across three pagination pages Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com>
# Conflicts: # .hark/changes/2026-10-02_zacchua_reject-blank-webhook-secrets.change.md # .hark/changes/2026-10-06_jar_add-v2-condition-singleton-api-resource-resource-url.change.md # .hark/changes/2026-10-08_jar_v2-search-support.change.md # .hark/changes/2026-10-27_zacchua_preserve-event-context.change.md # .hark/changes/2026-10-27_zacchua_update-bundled-ca-certificates.change.md # .hark/releases.json # CHANGELOG.md # VERSION # lib/stripe/api_requestor.rb # lib/stripe/api_version.rb # lib/stripe/errors.rb # lib/stripe/event_types.rb # lib/stripe/object_types.rb # lib/stripe/params.rb # lib/stripe/params/account_session_create_params.rb # lib/stripe/params/charge_capture_params.rb # lib/stripe/params/checkout/session_update_params.rb # lib/stripe/params/invoice_create_preview_params.rb # lib/stripe/params/payment_intent_confirm_params.rb # lib/stripe/params/payment_intent_create_params.rb # lib/stripe/params/payment_intent_update_params.rb # lib/stripe/params/v2/core/account_create_params.rb # lib/stripe/params/v2/core/account_token_create_params.rb # lib/stripe/params/v2/core/account_update_params.rb # lib/stripe/params/v2/core/vault/gb_bank_account_create_params.rb # lib/stripe/params/v2/money_management/outbound_payment_create_params.rb # lib/stripe/params/v2/money_management/outbound_setup_intent_create_params.rb # lib/stripe/params/v2/money_management/outbound_setup_intent_update_params.rb # lib/stripe/resources.rb # lib/stripe/resources/card.rb # lib/stripe/resources/dispute.rb # lib/stripe/resources/payment_intent.rb # lib/stripe/resources/v2/core/account.rb # lib/stripe/resources/v2/core/vault/gb_bank_account.rb # lib/stripe/resources/v2/core/vault/us_bank_account.rb # lib/stripe/resources/v2/money_management/adjustment.rb # lib/stripe/resources/v2/money_management/financial_account.rb # lib/stripe/resources/v2/money_management/inbound_transfer.rb # lib/stripe/resources/v2/money_management/outbound_payment.rb # lib/stripe/resources/v2/money_management/outbound_setup_intent.rb # lib/stripe/resources/v2/money_management/payout_method.rb # lib/stripe/resources/v2/money_management/received_credit.rb # lib/stripe/resources/v2/money_management/recipient_verification.rb # lib/stripe/services.rb # lib/stripe/services/v2/core_service.rb # lib/stripe/services/v2/money_management/financial_account_service.rb # lib/stripe/services/v2/money_management/payout_method_service.rb # lib/stripe/services/v2/money_management/test_helpers/financial_address_service.rb # lib/stripe/services/v2/money_management_service.rb # lib/stripe/services/v2_services.rb # lib/stripe/stripe_event_notification_handler.rb # lib/stripe/version.rb # rbi/stripe.rbi # rbi/stripe/params/account_create_params.rbi # rbi/stripe/params/account_session_create_params.rbi # rbi/stripe/params/account_update_params.rbi # rbi/stripe/params/charge_capture_params.rbi # rbi/stripe/params/checkout/session_update_params.rbi # rbi/stripe/params/invoice_create_preview_params.rbi # rbi/stripe/params/payment_intent_confirm_params.rbi # rbi/stripe/params/payment_intent_create_params.rbi # rbi/stripe/params/payment_intent_update_params.rbi # rbi/stripe/params/v2/core/account_create_params.rbi # rbi/stripe/params/v2/core/account_token_create_params.rbi # rbi/stripe/params/v2/core/account_update_params.rbi # rbi/stripe/params/v2/core/vault/gb_bank_account_create_params.rbi # rbi/stripe/params/v2/money_management/outbound_payment_create_params.rbi # rbi/stripe/params/v2/money_management/outbound_setup_intent_create_params.rbi # rbi/stripe/params/v2/money_management/outbound_setup_intent_update_params.rbi # rbi/stripe/resources/card.rbi # rbi/stripe/resources/dispute.rbi # rbi/stripe/resources/payment_intent.rbi # rbi/stripe/resources/v2/core/account.rbi # rbi/stripe/resources/v2/core/vault/gb_bank_account.rbi # rbi/stripe/resources/v2/core/vault/us_bank_account.rbi # rbi/stripe/resources/v2/money_management/adjustment.rbi # rbi/stripe/resources/v2/money_management/financial_account.rbi # rbi/stripe/resources/v2/money_management/inbound_transfer.rbi # rbi/stripe/resources/v2/money_management/outbound_payment.rbi # rbi/stripe/resources/v2/money_management/outbound_setup_intent.rbi # rbi/stripe/resources/v2/money_management/payout_method.rbi # rbi/stripe/resources/v2/money_management/received_credit.rbi # rbi/stripe/resources/v2/money_management/recipient_verification.rbi # rbi/stripe/services/v2/money_management/financial_account_service.rbi # rbi/stripe/services/v2/money_management/payout_method_service.rbi # rbi/stripe/services/v2/money_management/test_helpers/financial_address_service.rbi # rbi/stripe/services/v2/money_management_service.rbi # rbi/stripe/services/v2_services.rbi # rbi/stripe/stripe_event_notification_handler.rbi # test/stripe/generated_examples_test.rb
mark-kogan-stripe
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
What?
See Also
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.