Repository navigation
Make v2 search limit hoisting explicit - #2015
Merged
Merged
Conversation
Committed-By-Agent: goose Orbit-Session-Id: bf0045b8-bfc9-4e18-ae11-5f042ce9add7
Committed-By-Agent: goose Orbit-Session-Id: bf0045b8-bfc9-4e18-ae11-5f042ce9add7
jar-stripe
marked this pull request as ready for review
November 2, 2026 16:41
jar-stripe
requested review from
mark-kogan-stripe
and
a balanced review from Copilot
and removed request for
a team
November 2, 2026 16:41
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change making v2 search limit handling explicit.
No open issues 🎉
What changed in this PR
Makes v2 search limit handling explicit so search requests can be distinguished from custom operations with similar URL paths.
Changes:
- Moves limit preparation into
request_v2_search, which delegates once to ordinaryrequest. - Preserves caller parameters and existing query URLs while removing limits from search request bodies.
- Adds coverage for typed and hash parameters, custom operations, option forwarding, immutability, and dispatch counts.
| File | Description |
|---|---|
test/stripe/stripe_service_test.rb |
Tests explicit search preparation and unchanged custom-operation dispatch. |
lib/stripe/stripe_service.rb |
Replaces path-based limit handling with an explicit v2 search helper. |
Review effort: Balanced
Committed-By-Agent: goose Orbit-Session-Id: bf0045b8-bfc9-4e18-ae11-5f042ce9add7
jar-stripe
enabled auto-merge (squash)
November 2, 2026 18:24
zacchua-stripe
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
StripeService#request has special handling for v2 search methods. This handling is invoked when a POST method has a path that starts with /v2 and ends with search, but that is also a valid pattern for v2 custom operations. Our code generator needs to be able to generate code that adequately distinguishes between the two types of methods.
What?
StripeService#request_v2_search, delegating to ordinaryrequestexactly once; remove all path-based hoisting fromrequest.limit. Preserve caller params, request options, base address, usage, and transport behavior.limitfrom params if present and remove it from the copied body. Pagination uses ordinary requests and keeps server-authored page URLs unchanged.Validation:
just test,just lint-check, andjust typecheckpass. Focused service and pagination tests: 14 tests, 23 assertions.See Also
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.