Skip to content

Preserve event context on fetched related objects - #2009

Merged
zacchua-stripe merged 3 commits into
masterfrom
zacchua/run-devsdk-3614-event-context
Oct 28, 2026
Merged

zacchua-stripe merged 3 commits into
masterfrom
zacchua/run-devsdk-3614-event-context

Conversation

@zacchua-stripe

@zacchua-stripe zacchua-stripe commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Why?

Event notifications retained the original client, and active-resource instance methods used the global requestor instead of the requestor bound during deserialization. A fetched object could therefore lose the event context on a follow-up operation.

What?

  • bind event notifications to an event-scoped client
  • make active-resource operations prefer the object’s bound requestor
  • verify a fetched Product preserves Stripe-Context on deletion

See Also

http://go/j/RUN_DEVSDK-3614

Configuration

  • skip-changefile: This PR is not a user-facing change, so there's no changefile.

zacchua-stripe and others added 2 commits October 27, 2026 09:43
Committed-By-Agent: codex
Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex
Co-authored-by: codex <noreply@openai.com>
@zacchua-stripe
zacchua-stripe marked this pull request as ready for review October 27, 2026 23:29
@zacchua-stripe
zacchua-stripe requested a review from a team as a code owner October 27, 2026 23:29
@zacchua-stripe
zacchua-stripe requested review from mark-kogan-stripe and removed request for a team October 27, 2026 23:29

@jar-stripe jar-stripe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please dont merge without confirming the open question, otherwise gtg!

Comment thread lib/stripe/api_resource.rb Resolved
@zacchua-stripe
zacchua-stripe enabled auto-merge (squash) October 28, 2026 19:28
@zacchua-stripe
zacchua-stripe merged commit 3583c9a into master Oct 28, 2026
16 checks passed
@zacchua-stripe
zacchua-stripe deleted the zacchua/run-devsdk-3614-event-context branch October 28, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants