-
Notifications
You must be signed in to change notification settings - Fork 111
Enhanced broadcasting new API #1624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aleksandr-voitenko
wants to merge
13
commits into
staging
Choose a base branch
from
enhanced-broadcasting-new-api
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nals handling code
8f2a0b2 to
9f211b5
Compare
tests/osn-tests/src/test_osn_enhanced_broadcasting_advanced_streaming.ts
Fixed
Show fixed
Hide fixed
d99331e to
f68fb07
Compare
f68fb07 to
2a373b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code allows Enhanced Broadcasting to be used with the new back-end API.
At first I was trying to implement it as a simple Boolean flag in the settings, but soon realized that dual output mode would be near impossible to implement this way, so I came up to a new design.
Essentially, in the example above you see
AdvancedStreamingenhanced by the optional canvas.Interface of
Streaminghas also changes slightly. Now presence of an encoder is optional.Why this design?
Mainly because of the Twitch Dual Streaming mode that requires vertical and horizontal videos to be streamed to a single endpoint.
On top of that
I refactored and generalized code related to streaming. Additionally, improved encapsulation of several classes.
I refactored existing Enhanced Broadcasting code to support both new and old (
OBS_service) APIs. As a result, backward compatibility is enabled.And finally
Error handling has been improved, especially during stream start.
How Has This Been Tested?
Manually and via unit tests. Windows only.
Types of changes