test(e2e): fix dashboard mobile POM selector and preferences intercept#739
Open
steilerDev wants to merge 1 commit intobetafrom
Open
test(e2e): fix dashboard mobile POM selector and preferences intercept#739steilerDev wants to merge 1 commit intobetafrom
steilerDev wants to merge 1 commit intobetafrom
Conversation
- Add data-testid="dashboard-mobile-sections" to mobile sections container - Update DashboardPage POM to use getByTestId instead of mismatched aria-label (component uses "Dashboard overview" not "Dashboard overview (mobile)") - Remove preferences GET intercept from interceptDashboardApis that was preventing the "dismissed card stays hidden after reload" test from reading real server-side state. The global beforeEach reset is sufficient for test isolation. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-testid="dashboard-mobile-sections"to mobile sections containergetByTestIdinstead of mismatched aria-label ("Dashboard overview (mobile)" doesn't exist — actual label is "Dashboard overview")Fixes shards 4, 10, 15 failing on promotion PR #738.
Test plan
Co-Authored-By: Claude Opus 4.6 [email protected]