fix(e2e): update dashboard tests for timeline card split and UX review fixes#734
Closed
steilerDev wants to merge 4 commits intobetafrom
Closed
fix(e2e): update dashboard tests for timeline card split and UX review fixes#734steilerDev wants to merge 4 commits intobetafrom
steilerDev wants to merge 4 commits intobetafrom
Conversation
**Fix #731 — Invoice Pipeline Click-Through** - Wrap invoice row content in Link component - Navigate to /budget/invoices/{id} on click - Add itemLink CSS class for flex layout and focus states **Fix #730 — Split Timeline Status into Separate Cards** - Replace timeline-status card ID with three new IDs: upcoming-milestones, work-item-progress, critical-path - Remove cardSection and sectionHeader wrapper divs from sub-card components - Add milestone title Link to /schedule/milestones/{id} - Add critical path deadline Link to /work-items/{id} - Delete unused TimelineStatusCards.tsx wrapper and AtRiskItemsCard.tsx - Update CARD_DEFINITIONS to render 3 separate cards instead of composite **Fix #729 — Mini Gantt Current Week Redesign** - Change layout: ROW_HEIGHT 24→36, BAR_HEIGHT 16→24, BAR_HEIGHT_OFFSET 4→6, HEADER_HEIGHT 24→32 - Compute Monday-anchored week instead of 30-day window - Change header labels: day-of-month → day-of-week (Mon, Tue, etc.) - Simplify grid: 31 mixed-weight lines → 8 uniform day-boundary lines - Update today marker to compute relative to week start, only render if within bounds - Add title text labels on bars (truncated if width < 40px) - Remove dependency arrow rendering entirely - Update empty state: "next 30 days" → "this week" - Update SVG aria-label to reference "this week" Co-Authored-By: Claude frontend-developer (Haiku 4.5) <[email protected]>
- Delete AtRiskItemsCard.test.tsx (component removed in #730 split) - InvoicePipelineCard: add Test 13 verifying each invoice row links to /budget/invoices/<id> (Fix #731 click-through) - UpcomingMilestonesCard: add Test 11 verifying milestone title links to /schedule/milestones/:id (Fix #730 heading/link changes) - CriticalPathCard: add Test 11 verifying deadline links to /work-items/:id (Fix #730 heading/link changes) - MiniGanttCard: add daysFromMonday() helper, update all date fixtures to use Mon-Sun week window, update empty state text to "No work items scheduled this week", replace dependency-arrow line count test with grid-line stability assertion (8 lines, no dep arrows), update SVG aria-label assertion to include "this week" (Fix #729 mini Gantt current week redesign) - DashboardPage: replace 'Timeline Status' with 'Upcoming Milestones', 'Work Item Progress', 'Critical Path' in ALL_CARD_TITLES, update skeleton count 14→18 (9 data-backed cards × 2 layouts), fix Test 18 sibling card assertion to use 'Upcoming Milestones' Fixes #729, #730, #731 Co-Authored-By: Claude qa-integration-tester (Sonnet 4.5) <[email protected]>
…code - MiniGanttCard.tsx: Remove dead dependency arrow code (itemRowMap, visibleDependencies useMemo blocks, arrowDefault/arrowCritical color properties) — dependency arrows were previously removed, leaving stale code behind - MiniGanttCard.tsx: Replace hardcoded fill="white" on bar text with design token (--color-text-inverse) for dark mode compatibility - tokens.css: Add missing --color-warning-bg token (light: #fff7ed, dark: rgba(251, 146, 60, 0.1)) used by .badgeYellow in TimelineStatusCards and HouseholdItemDetailPage Co-Authored-By: Claude frontend-developer (Haiku 4.5) <[email protected]>
Replace the single 'Timeline Status' card references with the three separate cards introduced during UAT fixes: 'Upcoming Milestones', 'Work Item Progress', and 'Critical Path'. Updates DashboardCardId type, CARD_TITLES array, Scenario 2/4 test descriptions, and the dismiss button count assertion from 8 to 10. Co-Authored-By: Claude e2e-test-engineer (Opus 4.6) <[email protected]>
Owner
Author
|
Closing — will recreate from fresh beta base |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fill="white"→ design token, added--color-warning-bgtokenChanges
e2e/pages/DashboardPage.ts: UpdatedDashboardCardIdtype andCARD_TITLES(10 entries)e2e/tests/navigation/dashboard.spec.ts: Updated card count assertions, replaced "Timeline Status" test with 3 timeline card testsclient/src/components/MiniGanttCard/MiniGanttCard.tsx: Removed dead code, replaced hardcodedfill="white"with design tokenclient/src/styles/tokens.css: Added--color-warning-bgtoken (light + dark)Test plan
🤖 Generated with Claude Code