Update geom_errorbarh to geom_errorbar#188
Conversation
|
@luhann Thank you for noting this issue and submitting a PR! We really appreciate when people submit their own patches to issues they find in our software! However, I'm seeing failing R-CMD-checks (which I think is due to Thanks! |
|
Yup, I just noticed that now, I had fixed the error after I noticed the vignettes not building but forgot to amend this commit with the fix. It's supposed to be orientation = "y", but if you've included it in #189 I can go ahead and close this. |
|
Ok great, I'll close this and then merge PR #189. Thanks! |
|
Seconding Sarah's thanks for this and especially for TreeSummarizedExperiment @luhann . We appreciate it very much. |
Hi,
Thanks for all the work you do on corncob.
I am busy attempting to implement TreeSummarizedExperiment support for corncob, in the process I noticed that tests were giving a warning due to the fact that plot.differentialTest was using
geom_errorbarhwhich has been deprecated. This PR just updates the plot and all tests pass without issue now.