apollo_consensus_orchestrator,apollo_dashboard: add metric for last state commitment infos sent - #14897
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryLow Risk Overview The metric is registered in consensus orchestrator metrics and surfaced on the Cende Grafana row via a new stat panel (Rust dashboard builder and Reviewed by Cursor Bugbot for commit fd8d7f4. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d253d11. Configure here.
itamar-starkware
left a comment
There was a problem hiding this comment.
@itamar-starkware made 2 comments.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on yoavGrs).
crates/apollo_consensus_orchestrator/src/metrics.rs line 109 at r1 (raw file):
CENDE_WRITE_PREV_HEIGHT_BLOB_LATENCY.register(); CENDE_WRITE_BLOB_SUCCESS.register(); CENDE_LAST_STATE_COMMITMENT_INFOS_BLOCK_NUMBER.register();
It is a misleading name. Since the value is what "sent" to the cende recorder. You can keep the name if you wait for the write blob to finish or add the word "sent" in the end of the metric if you keep it as is.
…tate commitment infos sent
d253d11 to
fd8d7f4
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs made 2 comments.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on itamar-starkware).
crates/apollo_consensus_orchestrator/src/metrics.rs line 109 at r1 (raw file):
Previously, itamar-starkware wrote…
It is a misleading name. Since the value is what "sent" to the cende recorder. You can keep the name if you wait for the write blob to finish or add the word "sent" in the end of the metric if you keep it as is.
Moved.
itamar-starkware
left a comment
There was a problem hiding this comment.
@itamar-starkware reviewed 5 files and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
|
Security scan complete — no issues detected. Generated by Claude Code |


apollo_dashboard: make native compilation alert severity env-configurable (#14893)
Adds
[profile.dev] debug = "line-tables-only"to keep panic/backtracefile:line and tracing call-site info while dropping the full DWARF
variable/type info that dominates codegen time, linker memory, and
target/ disk. A
dev-debugprofile (cargo build --profile dev-debug)restores full debug info on demand.
Co-authored-by: Claude Opus 4.8 (1M context) noreply@anthropic.com
Replaces the hardcoded p4 severity with a per-environment placeholder, so
testnet and integration can run this alert at p5 while mainnet keeps p4.
Persists the manual override applied in starkware-envs-integration#2648.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
Co-authored-by: Avi Cohen avi.cohen@starkware.co
Co-authored-by: Claude Opus 4.8 (1M context) noreply@anthropic.com
apollo_consensus_orchestrator,apollo_dashboard: add metric for last state commitment infos sent