Skip to content

apollo_consensus_orchestrator,apollo_dashboard: add metric for last state commitment infos sent - #14897

Merged
yoavGrs merged 1 commit into
mainfrom
cende-commitment-infos-metrics
Aug 2, 2026
Merged

apollo_consensus_orchestrator,apollo_dashboard: add metric for last state commitment infos sent#14897
yoavGrs merged 1 commit into
mainfrom
cende-commitment-infos-metrics

Conversation

@yoavGrs

@yoavGrs yoavGrs commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

apollo_dashboard: make native compilation alert severity env-configurable (#14893)

Adds [profile.dev] debug = "line-tables-only" to keep panic/backtrace
file:line and tracing call-site info while dropping the full DWARF
variable/type info that dominates codegen time, linker memory, and
target/ disk. A dev-debug profile (cargo build --profile dev-debug)
restores full debug info on demand.

Co-authored-by: Claude Opus 4.8 (1M context) noreply@anthropic.com

  • apollo_dashboard: make native compilation alert severity env-configurable

Replaces the hardcoded p4 severity with a per-environment placeholder, so
testnet and integration can run this alert at p5 while mainnet keeps p4.
Persists the manual override applied in starkware-envs-integration#2648.

Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com

  • revert unwanted file

Co-authored-by: Avi Cohen avi.cohen@starkware.co
Co-authored-by: Claude Opus 4.8 (1M context) noreply@anthropic.com

apollo_consensus_orchestrator,apollo_dashboard: add metric for last state commitment infos sent

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

yoavGrs commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@yoavGrs yoavGrs self-assigned this Jul 29, 2026
@yoavGrs
yoavGrs requested a review from itamar-starkware July 29, 2026 14:46
@yoavGrs
yoavGrs marked this pull request as ready for review July 29, 2026 14:46
@cursor

cursor Bot commented Jul 29, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Observability-only gauge updates on existing success paths; no change to blob content or write logic beyond metrics.

Overview
Adds cende_last_state_commitment_infos_block_number observability for the os_input Cende path: a gauge records the block number of the newest state commitment infos included in a blob after a successful Aerospike write (from the last entry in recent_state_commitment_infos).

The metric is registered in consensus orchestrator metrics and surfaced on the Cende Grafana row via a new stat panel (Rust dashboard builder and dev_grafana.json). A stale TODO about this metric is removed from sequencer_consensus_context.

Reviewed by Cursor Bugbot for commit fd8d7f4. Bugbot is set up for automated code reviews on this repo. Configure here.

@yoavGrs yoavGrs changed the title apollo_dashboard: make native compilation alert severity env-configurable (#14893) apollo_consensus_orchestrator, apollo_dashboard: add metric for last state commitment infos block number Jul 29, 2026
@yoavGrs yoavGrs changed the title apollo_consensus_orchestrator, apollo_dashboard: add metric for last state commitment infos block number apollo_consensus_orchestrator,apollo_dashboard: add metric for last state commitment infos sent Jul 29, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d253d11. Configure here.

Comment thread crates/apollo_consensus_orchestrator/src/sequencer_consensus_context.rs Outdated

@itamar-starkware itamar-starkware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itamar-starkware made 2 comments.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on yoavGrs).


crates/apollo_consensus_orchestrator/src/metrics.rs line 109 at r1 (raw file):

    CENDE_WRITE_PREV_HEIGHT_BLOB_LATENCY.register();
    CENDE_WRITE_BLOB_SUCCESS.register();
    CENDE_LAST_STATE_COMMITMENT_INFOS_BLOCK_NUMBER.register();

It is a misleading name. Since the value is what "sent" to the cende recorder. You can keep the name if you wait for the write blob to finish or add the word "sent" in the end of the metric if you keep it as is.

Comment thread crates/apollo_consensus_orchestrator/src/sequencer_consensus_context.rs Outdated
@yoavGrs
yoavGrs force-pushed the cende-commitment-infos-metrics branch from d253d11 to fd8d7f4 Compare July 30, 2026 06:39

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs made 2 comments.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on itamar-starkware).


crates/apollo_consensus_orchestrator/src/metrics.rs line 109 at r1 (raw file):

Previously, itamar-starkware wrote…

It is a misleading name. Since the value is what "sent" to the cende recorder. You can keep the name if you wait for the write blob to finish or add the word "sent" in the end of the metric if you keep it as is.

Moved.

Comment thread crates/apollo_consensus_orchestrator/src/sequencer_consensus_context.rs Outdated

@itamar-starkware itamar-starkware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itamar-starkware reviewed 5 files and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@yoavGrs
yoavGrs added this pull request to the merge queue Aug 2, 2026
Merged via the queue into main with commit 2df7bcb Aug 2, 2026
38 of 42 checks passed

Copy link
Copy Markdown
Contributor

Security scan complete — no issues detected.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants