Skip to content

apollo_batcher: never log the committer output's compressed commitment infos - #14896

Open
yoavGrs wants to merge 1 commit into
mainfrom
remove-committer-output-debug
Open

apollo_batcher: never log the committer output's compressed commitment infos#14896
yoavGrs wants to merge 1 commit into
mainfrom
remove-committer-output-debug

Conversation

@yoavGrs

@yoavGrs yoavGrs commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@yoavGrs yoavGrs self-assigned this Jul 29, 2026

yoavGrs commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yoavGrs
yoavGrs requested a review from itamar-starkware July 29, 2026 12:54
@yoavGrs
yoavGrs marked this pull request as ready for review July 29, 2026 12:54
@cursor

cursor Bot commented Jul 29, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Observability-only change to logging and panic strings; commitment behavior and channel payloads are unchanged.

Overview
Prevents debug logs and panics from formatting full CommitterTaskOutput / CommitmentTaskOutput, which under os_input can include large compressed Patricia witness data in state_commitment_infos.

Debug is dropped from those output types. The state committer success log now records only task label and height (no output.clone() for logging). The expect_commitment revert panic message uses height instead of {:?} on the whole output.

Reviewed by Cursor Bugbot for commit 2b39643. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants