Conversation
…te_function_signature Two small cleanups in `write_function_signature`, split out of #10271 where they were flagged as correct but out of scope: - `syntactic_kind` is only ever read by value into a format string, and all four call sites pass a literal, so take it as `&str` and drop the `.to_string()` at each call site. - Inline `syntactic_kind` and `resolver_generic_params` into the format string, per the repo convention of inlining variable names where possible. Visibility and name stay positional since they are call expressions. No behavior change; no golden updates. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
PR SummaryLow Risk Overview The opening Reviewed by Cursor Bugbot for commit ea5908b. Bugbot is set up for automated code reviews on this repo. Configure here. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
This change is |
TomerStarkware
left a comment
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on eytan-starkware).
3 participants
Two small cleanups in
write_function_signature, split out of #10271 wherethey were flagged as correct but out of scope:
syntactic_kindis only ever read by value into a format string, and allfour call sites pass a literal, so take it as
&strand drop the.to_string()at each call site.syntactic_kindandresolver_generic_paramsinto the formatstring, per the repo convention of inlining variable names where possible.
Visibility and name stay positional since they are call expressions.
No behavior change; no golden updates.
cargo test -p cairo-lang-docpasseswith no golden diffs;
rust_fmt.shandclippy.share clean.🤖 Generated with Claude Code