feat(starknet): make deploy_v2_syscall usable for starknet - #10216
Draft
ron-starkware wants to merge 1 commit into
Draft
feat(starknet): make deploy_v2_syscall usable for starknet#10216ron-starkware wants to merge 1 commit into
ron-starkware wants to merge 1 commit into
Conversation
Add `deploy_v2_syscall` to the audited allowed-libfuncs list, cover it in the libfuncs_coverage contract (regenerating the sierra / contract_class / compiled_contract_class artifacts and the compiled-class-hash golden), and add a cairo-level deployment test. The deployment test (`test_deploy_v2_differs_from_deploy`) deploys the same class via `deploy_syscall` and `deploy_v2_syscall` and asserts the addresses differ (Blake-escaped vs Pedersen) and that the contract deployed at the Blake-escaped address works — pinning corelib -> sierra -> casm -> runner, including the `DeployV2` selector string. NOTE: hold this PR for the release decision — `audited.json` membership is what makes the libfunc declarable on mainnet and must wait for the measured-gas follow-up on the sequencer side (see the deploy_v2 handoff). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack — part 3 of 3 (base:⚠️ Hold for the release decision —
ron/deploy-v2/corelib).audited.jsonmembership is what makes the libfunc declarable on mainnet and must wait for the measured-gas follow-up on the sequencer side.deploy_v2_syscalladded toaudited.json.libfuncs_coveragecontract; regenerated.sierra/.contract_class.json/.compiled_contract_class.jsonartifacts + the compiled-class-hash golden (the large diff is the mechanical statement/var reindex from adding one libfunc — same as themeta_tx_v0coverage PR).test_deploy_v2_differs_from_deploy: deploys the same class viadeploy_syscallanddeploy_v2_syscall, asserts the addresses differ (Blake-escaped vs Pedersen) and the contract at the Blake-escaped address works — pinning corelib → sierra → casm → runner incl. theDeployV2selector string.🤖 Generated with Claude Code