K8s Client: Apply Pod Spec Annotations #3152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
applyPodTemplatePatchfunction inpkg/container/kubernetes/client.gowas only copying Labels from the pod template patch but NOT Annotations.Fixes #3153
Fix
Tests Created
Unit test (
pkg/container/kubernetes/client_test.go):TestApplyPodTemplatePatchAnnotations- Tests the function directlyE2E test (
test/e2e/chainsaw/operator/single-tenancy/test-scenarios/pod-annotations/):podTemplateSpecThe chainsaw tests previously failed without the fix: