Repository navigation
Fix/token lookup pruning - #498
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix token lookup pruning on databases with Non-C Collation
Description
With v0.10.0, the token used for keyset pagination was changed to hex encoded values to avoid issues with escaping characters. With that change, get_token_record ended up using C collation based on the results of the decode function. This makes sure that we save the token keys for collection and id to text before passing them to the item lookup so that there is no collation difference which prevented partition pruning and index scans.
This also stages a v0.10.2 release
Checklist
README.mdto reflect any new environment variables, configuration changes, or breaking updates.AI tool usage