Skip to content

fix: skip daemon-pty-adapter tests on Windows #7158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sudoeren wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: skip daemon-pty-adapter tests on Windows #7158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/daemon/daemon-pty-adapter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const { getMacDaemonSystemResolverHealthMock } = vi.hoisted(() => ({
getMacDaemonSystemResolverHealthMock: vi.fn(async () => 'unknown')
}))

const itOnPosix = process.platform === 'win32' ? it.skip : it
const describeOnPosix = process.platform === 'win32' ? describe.skip : describe

vi.mock('./daemon-health', async (importOriginal) => {
const actual = await importOriginal<typeof DaemonHealthModule>()
Expand Down Expand Up @@ -71,7 +71,7 @@ async function waitFor(predicate: () => boolean, timeoutMs = 2000): Promise<void
}
}

describe('DaemonPtyAdapter (IPtyProvider)', () => {
describeOnPosix('DaemonPtyAdapter (IPtyProvider)', () => {
let dir: string
let socketPath: string
let tokenPath: string
Expand Down Expand Up @@ -127,7 +127,7 @@ describe('DaemonPtyAdapter (IPtyProvider)', () => {
expect(result.id).toContain('wt-1')
})

itOnPosix('keeps plain Codex startup on the short daemon shell-ready timeout', async () => {
it('keeps plain Codex startup on the short daemon shell-ready timeout', async () => {
await adapter.spawn({
cols: 80,
rows: 24,
Expand All @@ -139,7 +139,7 @@ describe('DaemonPtyAdapter (IPtyProvider)', () => {
expect(lastSubprocess.write).toHaveBeenCalledWith('codex\n')
})

itOnPosix('waits for shell-ready for delivery-hinted Codex startup', async () => {
it('waits for shell-ready for delivery-hinted Codex startup', async () => {
await adapter.spawn({
cols: 80,
rows: 24,
Expand Down