fix(skills): rename skills/orca-computer -> skills/orca-computer-use#7046
Open
tmchow wants to merge 1 commit into
Open
fix(skills): rename skills/orca-computer -> skills/orca-computer-use#7046tmchow wants to merge 1 commit into
tmchow wants to merge 1 commit into
Conversation
The directory shipped as skills/orca-computer/, but the frontmatter name:, the guidance test, the computer-e2e workflow path filter, and the install command all use orca-computer-use. Because the folder name didn't match: - config/scripts/computer-use-skill-guidance.test.mjs readFileSync's skills/orca-computer-use/SKILL.md and throws ENOENT (this file is in the vitest include glob config/scripts/**/*.test.mjs, so pnpm test fails). - .github/workflows/computer-e2e.yml path filter skills/orca-computer-use/SKILL.md matches no file, so the computer e2e workflow stops triggering on edits. Renaming the folder to match the skill name fixes the test, the CI trigger, and folder/name parity in one move. No other change needed (all references already point at orca-computer-use).
|
Ready to review this PR? Stage has broken it down into 1 individual chapter for you:
Chapters generated by Stage for commit 33ad25c on Jul 1, 2026 8:55pm UTC. |
AmethystLiang
requested review from
Jinwoo-H
and removed request for
AmethystLiang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small optional fix stacked on top of this PR's branch — cherry-pick the commit or close this, whatever's easiest for you.
The issue
The renamed skill folder shipped as
skills/orca-computer/, but its frontmattername:, the tests, the CI path filter, and the install command all useorca-computer-use. Because the folder name doesn't match:config/scripts/computer-use-skill-guidance.test.mjsfails. It doesreadFileSync(skills/orca-computer-use/SKILL.md), which throwsENOENT. That file is in the vitestincludeglob (config/scripts/**/*.test.mjsinconfig/vitest.config.ts), sopnpm testbreaks.computer-e2eworkflow stops triggering..github/workflows/computer-e2e.yml's path filterskills/orca-computer-use/SKILL.mdmatches no file, so edits to this skill no longer fire the workflow.Verification
Replicating the test's exact path resolution against both trees:
Grepped the branch: the only other reference to the old
skills/orca-computerpath is a prose line inorca-skill-naming.md("Do not bundle `skills/orca-computer`"), which this rename makes true. No code/config points at the old path, so the rename alone fixes everything — no changes needed to the test or workflow (they already targetorca-computer-use).Separate, non-blocking notes on the skill authoring (identity of
orcavsorca-cli, doc-vs-code divergence) are in line comments on the main PR.