Skip to content

Update x1_g4_series.py - #214

Closed
Disco402 wants to merge 1 commit into
squishykid:masterfrom
Disco402:master
Closed

Update x1_g4_series.py#214
Disco402 wants to merge 1 commit into
squishykid:masterfrom
Disco402:master

Conversation

@Disco402

Copy link
Copy Markdown

My X1 Mini G4 returns a data list of length 300

X1 Mini G4: ARM: v39, DSP: v32
WIFI+LAN: v1.005.04

Example JSON response:
{"sn":"XXXXXXX","ver":"1.005.04","type":22,"Data":[2432,52,4993,1263,1909,0,14644,10,67,0,2,0,0,1293,0,0,0,0,0,1405,0,110,2500,42,38,0,1,0,3349,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,0,0,0,96,0,0,7,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],"Information":[2.500,22,"XXXXXXX",13,0.32,0.00,0.39,0.00,0.00,1]}

My X1 Mini G4 returns a data list of lenth 300

X1 Mini G4: ARM: v39, DSP: v32
WIFI+LAN: v1.005.04

@kdehairy kdehairy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use ranges. Leave the current length constraint as is. Add another one with min == max == 300

Changing the constraint on the schema to be a range make it more permissive than necessary/correct. E.g. a range 100-300 makes this constraint pass for other inverters that has 200 data registers.

@Disco402

Copy link
Copy Markdown
Author

@kdehairy fair enough, looks like this is a duplicate of #210 which has your preference.

Can that be merged? It's been open since April...

@Disco402

Copy link
Copy Markdown
Author

Duplicate of #197 and #210 - Closing as they are better coded

@Disco402 Disco402 closed this Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants