Update x1_g4_series.py - #214
Closed
Disco402 wants to merge 1 commit into
Closed
Conversation
My X1 Mini G4 returns a data list of lenth 300 X1 Mini G4: ARM: v39, DSP: v32 WIFI+LAN: v1.005.04
kdehairy
reviewed
Jul 11, 2026
kdehairy
left a comment
Contributor
There was a problem hiding this comment.
Please don't use ranges. Leave the current length constraint as is. Add another one with min == max == 300
Changing the constraint on the schema to be a range make it more permissive than necessary/correct. E.g. a range 100-300 makes this constraint pass for other inverters that has 200 data registers.
Author
This was referenced Jul 11, 2026
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My X1 Mini G4 returns a data list of length 300
X1 Mini G4: ARM: v39, DSP: v32
WIFI+LAN: v1.005.04
Example JSON response:
{"sn":"XXXXXXX","ver":"1.005.04","type":22,"Data":[2432,52,4993,1263,1909,0,14644,10,67,0,2,0,0,1293,0,0,0,0,0,1405,0,110,2500,42,38,0,1,0,3349,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,0,0,0,96,0,0,7,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],"Information":[2.500,22,"XXXXXXX",13,0.32,0.00,0.39,0.00,0.00,1]}