This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Do not remove images that did not exist in the last run#97
Open
pdericson wants to merge 1 commit intospotify:masterfrom
pdericson:master
Open
Do not remove images that did not exist in the last run#97pdericson wants to merge 1 commit intospotify:masterfrom pdericson:master
pdericson wants to merge 1 commit intospotify:masterfrom
pdericson:master
Conversation
If an image did not exist in the last run then it may have just been created. If the image has just been created and we remove it then we might encounter: #43 There are two outstanding issues related to #43 1. It is stated in moby/moby#8926 (comment) that the fix while applicable to `docker pull` may not fix the issue for `docker build` 2. The fix for moby/moby#8926 has not been back ported to Docker 1.7.1 (the last version of Docker supported on RHEL 6) While most people do not care about (2), (1) may still be an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an image did not exist in the last run then it may have just been created.
If the image has just been created and we remove it then we might encounter:
#43
There are two outstanding issues related to #43
docker pullmay not fix the issue fordocker buildWhile most people do not care about (2), (1) may still be an issue.