Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
run: BUILD_BRANCH=$(echo "${GITHUB_REF#refs/heads/}") npm run build

- name: Store assets
if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/development' || github.ref == 'refs/heads/main') }}
if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/fme-12310' || github.ref == 'refs/heads/main') }}
uses: actions/upload-artifact@v5
with:
name: assets
Expand All @@ -57,7 +57,7 @@ jobs:
name: Upload assets
runs-on: ubuntu-latest
needs: build
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/development' }}
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/fme-12310' }}
strategy:
matrix:
environment:
Expand Down
18 changes: 9 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@splitsoftware/splitio-browserjs",
"version": "1.6.1",
"version": "1.6.2-rc.5",
"description": "Split SDK for JavaScript on Browser",
"main": "cjs/index.js",
"module": "esm/index.js",
Expand Down Expand Up @@ -59,7 +59,7 @@
"bugs": "https://github.com/splitio/javascript-browser-client/issues",
"homepage": "https://github.com/splitio/javascript-browser-client#readme",
"dependencies": {
"@splitsoftware/splitio-commons": "2.10.1",
"@splitsoftware/splitio-commons": "2.10.2-rc.7",
"tslib": "^2.3.1",
"unfetch": "^4.2.0"
},
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/browserSuites/push-corner-cases.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export function testSplitKillOnReadyFromCache(fetchMock, assert) {
});
client.on(client.Event.SDK_READY, () => {
const lapse = Date.now() - start;
assert.true(nearlyEqual(lapse, MILLIS_SPLIT_CHANGES_RESPONSE), 'SDK_READY once split changes arrives');
assert.true(nearlyEqual(lapse, MILLIS_SPLIT_CHANGES_RESPONSE, 200), 'SDK_READY once split changes arrives');

client.destroy().then(() => { assert.end(); });
});
Expand Down
2 changes: 1 addition & 1 deletion src/settings/defaults.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type SplitIO from '@splitsoftware/splitio-commons/types/splitio';
import { LogLevels, isLogLevelString } from '@splitsoftware/splitio-commons/src/logger/index';
import { CONSENT_GRANTED } from '@splitsoftware/splitio-commons/src/utils/constants';

const packageVersion = '1.6.1';
const packageVersion = '1.6.2-rc.5';

/**
* In browser, the default debug level, can be set via the `localStorage.splitio_debug` item.
Expand Down
61 changes: 59 additions & 2 deletions ts-tests/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -278,12 +278,12 @@ client = client.removeAllListeners();

// Ready and destroy
let promise: Promise<void> = client.ready();
promise = client.whenReady();
promise = client.destroy();
promise = SDK.destroy();
// @TODO not public yet
// promise = client.flush();
const promiseWhenReadyFromCache: Promise<boolean> = client.whenReadyFromCache();
let promiseWithMetadata: Promise<SplitIO.SdkReadyMetadata> = client.whenReady();
promiseWithMetadata = client.whenReadyFromCache();

// Get readiness status
let status: SplitIO.ReadinessStatus = client.getStatus();
Expand Down Expand Up @@ -374,6 +374,63 @@ tracked = client.track('myTrafficType', 'myEventType', 10);
tracked = client.track('myTrafficType', 'myEventType', null, { prop1: 1, prop2: '2', prop3: false, prop4: null });
// tracked = client.track('myEventType', undefined, { prop1: 1, prop2: '2', prop3: false, prop4: null }); // Not valid in Browser JS SDK

/*** Tests for SDK Update Metadata ***/

// Using addListener with typed metadata
client.addListener(client.Event.SDK_UPDATE, (metadata: SplitIO.SdkUpdateMetadata) => {
const type: SplitIO.SdkUpdateMetadataType = metadata.type;
const names: string[] = metadata.names;
});
client.addListener(client.Event.SDK_READY, (metadata: SplitIO.SdkReadyMetadata) => {
const fromCache: boolean = metadata.initialCacheLoad;
const timestamp: number = metadata.lastUpdateTimestamp;
});
client.addListener(client.Event.SDK_READY_FROM_CACHE, (metadata: SplitIO.SdkReadyMetadata) => {
const fromCache: boolean = metadata.initialCacheLoad;
const timestamp: number = metadata.lastUpdateTimestamp;
});
client.addListener(client.Event.SDK_UPDATE, () => { });
client.addListener(client.Event.SDK_READY, () => { });
client.addListener(client.Event.SDK_READY_FROM_CACHE, () => { });

// Using once with typed metadata
client.once(client.Event.SDK_UPDATE, (metadata: SplitIO.SdkUpdateMetadata) => {
const type: SplitIO.SdkUpdateMetadataType = metadata.type;
const names: string[] = metadata.names;
});
client.once(client.Event.SDK_READY, (metadata: SplitIO.SdkReadyMetadata) => {
const fromCache: boolean = metadata.initialCacheLoad;
const timestamp: number = metadata.lastUpdateTimestamp;
});
client.once(client.Event.SDK_READY_FROM_CACHE, (metadata: SplitIO.SdkReadyMetadata) => {
const fromCache: boolean = metadata.initialCacheLoad;
const timestamp: number = metadata.lastUpdateTimestamp;
});
client.once(client.Event.SDK_UPDATE, () => { });
client.once(client.Event.SDK_READY, () => { });
client.once(client.Event.SDK_READY_FROM_CACHE, () => { });

// SDK_READY event listener with metadata
client.on(client.Event.SDK_READY, (metadata: SplitIO.SdkReadyMetadata) => {
const fromCache: boolean = metadata.initialCacheLoad;
const timestamp: number = metadata.lastUpdateTimestamp;
});

// SDK_READY_FROM_CACHE event listener with metadata
client.on(client.Event.SDK_READY_FROM_CACHE, (metadata: SplitIO.SdkReadyMetadata) => {
const fromCache: boolean = metadata.initialCacheLoad;
const timestamp: number = metadata.lastUpdateTimestamp;
});

// SDK_UPDATE event listener with metadata
client.on(client.Event.SDK_UPDATE, (metadata: SplitIO.SdkUpdateMetadata) => {
const type: SplitIO.SdkUpdateMetadataType = metadata.type;
const names: string[] = metadata.names;
});
client.on(client.Event.SDK_UPDATE, () => { });
client.on(client.Event.SDK_READY, () => { });
client.on(client.Event.SDK_READY_FROM_CACHE, () => { });

/*** Repeating tests for Async Client ***/

// Events constants we get (same as for sync client, just for interface checking)
Expand Down