feat: translate page titles via generateMetadata - #537
Open
marioommg wants to merge 1 commit into
Open
Conversation
Use next-intl in server page/layout metadata so browser tabs follow the selected locale. Avoid client modules and rich-text homepage strings for document titles. Resolves spliit-app#325 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateMetadata+getTranslations, so they follow the selected locale (Page titles not working with translations #325).page.tsx/layout.tsxfiles (nogenerateMetadatain client components).Homepage.metaTitle,Groups.createGroup) instead of rich-text or empty-state strings.Related: builds on the same idea as #502, but avoids the issues in that branch (client +
next-intl/server,Homepage.titlewith<strong>tags, andGroups.NoRecent.createfor the create-group page).Test plan
<strong>tags