Trim large span attributes at record time to bound trace memory#85
Open
rubenvanassche wants to merge 1 commit into
Open
Trim large span attributes at record time to bound trace memory#85rubenvanassche wants to merge 1 commit into
rubenvanassche wants to merge 1 commit into
Conversation
Bound retained trace memory by dropping oversized string/array attributes per span/span-event via a configurable byte budget (max_attribute_size_in_kb, default 32KB). Opt in per recorder; enabled for queries and glows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query-heavy commands (e.g. thousands of bulk
upsert()s) could accumulate multi-MB query spans in memory until the process hitmemory_limit, since spans are retained for the whole trace and the existingReportTrimmeronly runs at send time. This adds aLargeAttributesTrimmingRecordertrait that, at record time, drops any string or array attribute exceeding a configurable byte budget (max_attribute_size_in_kb, default 32KB) using an allocation-free early-exitAttributeSizeLimiter, incrementing the OpenTelemetrydroppedAttributesCount. Trimming is opt-in per recorder viashouldTrimAttributes()(off by default) and is enabled forQueryRecorderandGlowRecorder, covering both spans and span events. Scalars, bools, floats and enums are never touched, and0disables trimming. Downstream note:laravel-flaremirrors this trace-limits config and will need the samemax_attribute_size_in_kbkey added.