Skip to content

add newest zsh version from zsh tests#1071

Open
PDoakORNL wants to merge 10 commits into
spack:developfrom
PDoakORNL:zsh_test_versions
Open

add newest zsh version from zsh tests#1071
PDoakORNL wants to merge 10 commits into
spack:developfrom
PDoakORNL:zsh_test_versions

Conversation

@PDoakORNL

@PDoakORNL PDoakORNL commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Zsh 5.9 has build issues with newer gcc's, newer distros and/or ncurses.
see issue #1024
This should supercede PR's #1025, #567

This PR adds version 5.9.0.2 a "test" version which fixes these issues for me.

Since the zsh release schedule seems quite conservative and many distros just apply a large number of patches, I don't really anticipate this becoming an official "release" in a timely manner. I have found no issues with zsh 5.9.0.2 on ubuntu or the SUSE derive cray os on Frontier.

Spack does provide git branch or commit based versions of some packages but here I think just providing the newest test tarball is sufficient.

@tldahlgren tldahlgren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all of the version sha256s (since url_for_version is introduced).

Please move the method below the directives.

Comment thread repos/spack_repo/builtin/packages/zsh/package.py Outdated
@tldahlgren tldahlgren self-assigned this Oct 16, 2025
@PDoakORNL PDoakORNL requested a review from tldahlgren February 6, 2026 22:48
tldahlgren
tldahlgren previously approved these changes Feb 11, 2026

@tldahlgren tldahlgren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Re)Confirmed all of the version sha256s since url_for_version is introduced.

@tldahlgren

Copy link
Copy Markdown
Contributor

Looks like there are several CI build failures related to zsh (e.g., https://gitlab.spack.io/spack/spack-packages/-/jobs/20203696).

Comment thread repos/spack_repo/builtin/packages/zsh/package.py Outdated
Co-authored-by: Greg Becker <becker33@llnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants