feat: allow indexing binary files via --allow_binary flag#7
Open
sudhanshu112233shukla wants to merge 3 commits intosourcebot-dev:mainfrom
Open
feat: allow indexing binary files via --allow_binary flag#7sudhanshu112233shukla wants to merge 3 commits intosourcebot-dev:mainfrom
sudhanshu112233shukla wants to merge 3 commits intosourcebot-dev:mainfrom
Conversation
Author
|
the Semgrep - SAST Scan is failing because the workflow in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes sourcebot-dev/sourcebot#575
This PR adds support for indexing binary files (files containing null bytes), which are currently skipped by default.
Problem
Currently, IndexBuilder detects files with null bytes (0x00) and marks them as "binary", verifying them with DocChecker. This prevents users from indexing and searching content within binary-like formats (e.g., PDFs, binary-encoded text) if they choose to do so.
Solution
AllowBinaryfield to IndexBuilder andbuild.Options.DocChecker.Checkto accept anallowBinaryboolean.IndexBuilder.Addto bypass the null-byte check whenAllowBinaryis true.Verification