Draft
Conversation
…r support - Add cachedPermittedExternalAccounts JSON field to Repo table - Update repoPermissionSyncer to cache external account IDs during sync - Add TypeScript schema for cached external accounts structure - Create utility functions to rebuild join table from cached data - Integrate permission rebuild into auth flow for new account linking - Support multiple provider types (GitHub, GitLab, etc.) Co-authored-by: brendan <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache external account IDs in the Repo table to enable immediate multi-provider repo access upon account linking and reduce permission sync overhead.
This PR introduces a
cachedPermittedExternalAccountsJSONB field to theRepotable. TherepoPermissionSyncernow populates this field with external account IDs for each provider (e.g.,{"github": ["123", "456"], "gitlab": ["789"]}). A new utility function,rebuildPermissionsFromCache, is integrated into the authentication flow to grant repo permissions instantly when an external account is linked or updated, leveraging this cached data. This ensures users gain access without waiting for a full permission sync and supports a multi-provider architecture.Slack Thread