Fix inverted vim's popup menu for dark theme.#106
Open
lkhphuc wants to merge 1 commit intosonph:masterfrom
lkhphuc:master
Open
Fix inverted vim's popup menu for dark theme.#106lkhphuc wants to merge 1 commit intosonph:masterfrom lkhphuc:master
lkhphuc wants to merge 1 commit intosonph:masterfrom
lkhphuc:master
Conversation
|
Hi, I think the popup parts should should be exchanged from and on lines 88 and 90, accordingly. |
|
Fixes #111 |
|
How come this is still not merged? I think fixing this would spare many users of this theme trouble |
BBaoVanC
added a commit
to BBaoVanC/onehalf
that referenced
this pull request
Mar 28, 2022
|
Is there a way to apply this "localy" so we don't have to wait for this to be merged? |
|
@mentos1386 probably the easiest way is to use |
dwettstein
added a commit
to dwettstein/onehalf
that referenced
this pull request
Nov 11, 2023
Resolves sonph#111 * mr-upstream-106: Update onehalfdark.vim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
Fix according to the light theme.