skip test_pfcwd_interval on SN6600_LD lossy-only hwsku - #27856
Open
ytzur1 wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
github-actions
Bot
requested review from
BYGX-wcr,
xwjiang-ms and
yutongzhang-microsoft
September 10, 2026 10:57
|
@StormLiangMS @wangxin @yxieca A user wants to merge changes to the conditional mark files into |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Signed-off-by: Yael Tzur <ytzur@nvidia.com>
ytzur1
force-pushed
the
ytzur1/cr335361-skip-test-pfcwd-interval
branch
from
September 10, 2026 11:10
45421d1 to
fed56ac
Compare
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Collaborator
|
This PR has backport request for branch(es): 202605. ---Powered by SONiC BuildBot
|
Collaborator
|
This PR has backport request label(s) for branch(es): 202605, but is missing required test information. Please make sure you tick the tested branch(es) in the Tested branch section and provide test evidence (e.g., 202605: <test result>) in the Test result section as well in your PR description. ---Powered by SONiC BuildBot
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I4acd3973c51e2a52c7c5a6c639df98de08e1ead5
Description of PR
Skip
generic_config_updater/test_pfcwd_interval.pyon the SN6600_LD lossy-only hwskus (Mellanox-SN6600_LD-P128C2andMellanox-SN6600_LD-P64O128C2).Summary:
Fixes # (issue)
test_pfcwd_intervalrequires a lossless configuration, which is not available on these lossy-only SN6600_LD hwskus, so the test is not applicable there. This adds those two hwskus to the existinghwsku in [...]skip condition for the test intests_mark_conditions.yaml.Type of change
Back port request
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO):
Failure type:
Tested branch
Test result
test skipped on skus like expected
Approach
What is the motivation for this PR?
test_pfcwd_intervalneeds a lossless configuration that does not exist on the SN6600_LD lossy-only hwskus, so it is not applicable and should be skipped there.How did you do it?
Added
Mellanox-SN6600_LD-P128C2andMellanox-SN6600_LD-P64O128C2to thehwsku in [...]skip condition ofgeneric_config_updater/test_pfcwd_interval.pyintests/common/plugins/conditional_mark/tests_mark_conditions.yaml.How did you verify/test it?
Verified the conditional-mark entry parses and that the test is skipped on the listed SN6600_LD hwskus.
Any platform specific information?
Applies to Mellanox SN6600_LD lossy-only hwskus (
Mellanox-SN6600_LD-P128C2,Mellanox-SN6600_LD-P64O128C2).Supported testbed topology if it's a new test case?
Documentation