bgp/test_prefix_list_suppress.py add wait_until for syslog - #27839
Open
arista-nwolfe wants to merge 1 commit into
Open
bgp/test_prefix_list_suppress.py add wait_until for syslog#27839arista-nwolfe wants to merge 1 commit into
bgp/test_prefix_list_suppress.py add wait_until for syslog#27839arista-nwolfe wants to merge 1 commit into
Conversation
The test expects bgpcfgd to emit syslog 'AsPath Manager is enabled for' But sometimes the assertion is seen before the syslog shows up Add a wait_until to give bgpcfgd a chance to emit the syslog sonic-net#27837 Signed-off-by: Nathan Wolfe <nwolfe@arista.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Collaborator
|
This PR has backport request for branch(es): 202605. ---Powered by SONiC BuildBot
|
Collaborator
|
The Tested branch section has been ticked and Test result is provided for branch(es): 202605. Added label(s): Tested for 202605 Branch. ---Powered by SONiC BuildBot
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#27837
Description of PR
The test
bgp/test_prefix_list_suppress.py::TestAnchorPrefixRegression::test_prefix_list_mgr_running_on_every_deviceexpects bgpcfgd to emit syslog 'AsPath Manager is enabled for'But sometimes the assertion is seen before the syslog shows up (see #27837)
Add a wait_until to give bgpcfgd a chance to emit the syslog
Summary:
Fixes #27837
Type of change
Back port request
Tested branch
Test result
Approach
What is the motivation for this PR?
If bgpcfgd is slower to emit the syslog we shouldn't cause the test to fail
How did you do it?
Convert syslog read and assert into a
wait_untilHow did you verify/test it?
Ran the
bgp/test_prefix_list_suppress.py::TestAnchorPrefixRegression::test_prefix_list_mgr_running_on_every_deviceagainst a UT2 20 times without failureAny platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A