Repository navigation
Multi-Instrument-Plot: Add offline mode support - #187
Merged
Merged
Conversation
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds improved offline support and more robust error handling for network connectivity issues across the multi-instrument plotting package, covering #170. The main changes introduce an
offlineoption to control data downloading behavior, propagate this flag through data loading functions, and handle network-related exceptions more gracefully to provide clearer error messages when data cannot be fetched due to connectivity problems.Offline Mode Support:
offlineattribute to theOptionsclass inmulti_inst_plots/__init__.py, enabling users to specify whether the application should attempt to download data or work offline.load_datainl1_tools.py,psp_tools.py,solo_tools.py,stereo_tools.py) to propagate theofflineflag and pass it to underlying data loader functions, ensuring consistent offline behavior throughout the codebase. [1] [2] [3] [4]wind3dp_load,soho_load,epd_load,psp_isois_load,stereo_load) to accept and use theofflineargument, preventing data downloads when offline mode is enabled. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Network Error Handling:
URLErrorin Wind WAVES CDF downloads to catch and report failures due to network issues. [1] [2]requests.ConnectionErrorandConnectionErrorin STIX and GOES/XRS loaders, providing user-friendly messages when data cannot be fetched due to lack of internet connectivity. [1] [2] [3]These changes make the package more robust for users working in environments with limited or no internet access and provide clearer feedback when data cannot be retrieved due to network issues.