Repository navigation
Electron capabilities updated with bonus ODRpack - #185
Merged
Merged
Conversation
Including new observers and electron studies.
EPI-Lo a bit testy with the meta data, so only using sun/asun directions for now.
Contributor
Author
|
pre-commit.ci autofix |
Member
|
From the tests it looks good to merge. Only noticed that there are still some new comments introduced, where I'm not sure if the intention was to keep them inside (cf. https://github.com/soler-he/sep_tools/pull/185/changes) |
Contributor
Author
|
Im mostly concerned with the front-end at the moment. The behind the scenes will be fixed in the next push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added easier access to changing between energy-species combinations (still a bit tedious though). Results just about match the paper now though.
Turned on ODRpack package so that should be fully functioning now.
Set up to run low energy electrons as a default now, will be updated soon.