-
-
Notifications
You must be signed in to change notification settings - Fork 720
chore: add support for react-native@0.87.0-rc.3 #4375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
37b7f00
Apply diff from upgrade helper
t0maboro 0d868d1
Fix some types
t0maboro 5bbb25e
Fix SearchBar typing
t0maboro 8368572
Unstage some changes
t0maboro 32bb39f
Fix TS errors in Screen.tsx
t0maboro 1a4570a
Formatting
t0maboro ff78cfa
fix codegen
t0maboro 78b6901
Add missing defaultProps assignments
t0maboro 2c54e1e
Upgrade react-native-safe-area-context
t0maboro 6ef3515
Fix for AGP 9
t0maboro 54c2e57
Rename
t0maboro 33ea883
Upgrade to rc3
t0maboro 2c32054
Revert changes fixed in core generated types
t0maboro e72f64d
Add explicit type casting to HostComponent
t0maboro f99b393
Formatting
t0maboro c376421
Add explicit types
t0maboro 7da02c2
Fix refs resolution to non-public ReactNativeElement
t0maboro 53f25c6
Add explicit type for TransitionProgressContextBody
t0maboro a07c0f4
Explicitly set rootDir for ts6
t0maboro 5790409
Restore Jest test-runner globals
t0maboro afe0ffb
feat: adopt AGP v9 with backward compat
hurali97 cd63f7b
Move defaultProps to initState
t0maboro 681763e
Rename interface
t0maboro 0aa3744
Change to ComponentRef
t0maboro 663cd36
Restore comment
t0maboro f6cbae3
restore srcDirs
t0maboro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we also need to apply the same update to library-level
gradle-wrapper.properties?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided not to bump because it hasn't been bumped in many previous RN upgrades; tbh, not sure whether we should consider bumping that, but I think this might be another topic - the Kotlin version for the library is still set to
1.8.0while on the example app's side it is 2+. I'd leave it as-is for now.