Match 6 more NandUtil_* functions#305
Open
chrisking1981 wants to merge 1 commit into
Open
Conversation
Adds matching implementations (verified 100% byte-match via objdiff) for: - NandUtil_getLength - NandUtil_createDir - NandUtil_create - NandUtil_delete - NandUtil_setStatus - NandUtil_getStatus Also corrects the existing NandUtil_getStatus header signature from (void*, void*) to (const char*, NANDStatus*) to reflect actual usage. Verified: 11/11 functions in NandUtil.o now match 100%. ROM-level main.dol and StaticR.rel sha1 are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds matching (100% byte-match) implementations for 6 previously-undefined
NandUtil_*functions:NandUtil_getLengthNandUtil_createDirNandUtil_createNandUtil_deleteNandUtil_setStatusNandUtil_getStatusAlso fixes the
NandUtil_getStatusheader signature (was(void*, void*), actually(const char*, NANDStatus*)).Test plan
NandUtil.oreport 100% matchmain.dolsha1ac7d72448630ade7655fc8bc5fd7a6543cb53a49StaticR.relsha1887bcc076781f5b005cc317a6e3cc8fd5f911300🤖 Generated with Claude Code